From owner-svn-src-head@freebsd.org Tue Mar 7 03:08:44 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 681BED0045F; Tue, 7 Mar 2017 03:08:44 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x244.google.com (mail-pg0-x244.google.com [IPv6:2607:f8b0:400e:c05::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3593814B1; Tue, 7 Mar 2017 03:08:44 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x244.google.com with SMTP id b5so4663043pgg.1; Mon, 06 Mar 2017 19:08:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=SQhwi73/pXfNGUlNXQuNzJvoRbfzskMEndUmtbvfkXo=; b=YxowizEdo5BBL957an/wvyMNIaU71PwG0bqb2UPrdz6pqAhRG5fZwYx/SbLuge+urS AYsc+RiGH+brk5VLEVGCudqZM647f421OK1JgVJBD2UnRqWKOGRJYRb6sKaMUTc+5Vxp QCE/DV7JPcco46w6DHrkVgjbipWSSjly/c5zqP6vuu3J4yqQDIEYrteI4YGxDl8b/B/e CH+yFsfogJLtQulXbVmKofoDtbVhGdzNDde3cHgP2q4v7Ui7wVQQDJY5Jadmt6b0xYaZ gLr6ZiauWUniZJ79cn5KmHZW/85DGFumzr/HejG5/598kxqwYNNVGZCGOFTzuxonnjpQ cxnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=SQhwi73/pXfNGUlNXQuNzJvoRbfzskMEndUmtbvfkXo=; b=VTgj41QjOoS9BAi7kVGWZEv3TqyYF6UIWO7tD2Cbm+XTm5aHO3RdkHvXI2rLsxH9Wo KJ54QpjaevziTNCX2S1OXbAQLmd5YTp3/wjYKrnZSnOkX9MHYgWuP5kp7yo6DJmhmE7m i83IuQrnlIqvZjmVwFPpnpW8EudR2C7OODVNCZXvawvox62hnaIng5iK7ylrc1aQshlQ LNYEGzM7/6onc8a/Lqy5lH8xihnFxMQqiOWzTcEuKk4hwvzDt4Sfe4m2pWBvoz1rge3j brjUd9fQb3tp9Y+CEKI/ZHoDUdi2FZ6ceWCKduRujewH2RTJCR22yhlob7+5p4V+a8n8 Afgg== X-Gm-Message-State: AMke39kPuLXBLyAaruOrCfStOvbvaovNlBSIJ5mgQw99Oi+l8Mvy0ZaLgiVThMFHgTXMbg== X-Received: by 10.84.199.170 with SMTP id r39mr31533883pld.144.1488856123413; Mon, 06 Mar 2017 19:08:43 -0800 (PST) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id t6sm42394464pgo.42.2017.03.06.19.08.42 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 06 Mar 2017 19:08:42 -0800 (PST) Subject: Re: svn commit: r314813 - head/sys/kern Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_EC34DEF2-B0E7-49DF-9080-3BD8406A1988"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <201703070020.v270K2vA039655@repo.freebsd.org> Date: Mon, 6 Mar 2017 19:08:41 -0800 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <9747B513-8D23-487D-8FF9-721265C1CF44@gmail.com> References: <201703070020.v270K2vA039655@repo.freebsd.org> To: Hiren Panchasara X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 03:08:44 -0000 --Apple-Mail=_EC34DEF2-B0E7-49DF-9080-3BD8406A1988 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 6, 2017, at 16:20, Hiren Panchasara wrote: >=20 > Author: hiren > Date: Tue Mar 7 00:20:01 2017 > New Revision: 314813 > URL: https://svnweb.freebsd.org/changeset/base/314813 >=20 > Log: > We've found a recurring problem where some userland process would be > stuck spinning at 100% cpu around sbcut_internal(). Inside > sbflush_internal(), sb_ccc reached to about 4GB and before passing it > to sbcut_internal(), we type-cast it from uint to int making it -ve. >=20 > The root cause of sockbuf growing this large is unknown. Correct fix > is also not clear but based on mailing list discussions, adding > KASSERTs to panic instead of looping endlessly. >=20 > Reviewed by: glebius > Sponsored by: Limelight Networks >=20 > Modified: > head/sys/kern/uipc_sockbuf.c >=20 > Modified: head/sys/kern/uipc_sockbuf.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/kern/uipc_sockbuf.c Tue Mar 7 00:13:53 2017 = (r314812) > +++ head/sys/kern/uipc_sockbuf.c Tue Mar 7 00:20:01 2017 = (r314813) > @@ -1043,6 +1043,11 @@ sbcut_internal(struct sockbuf *sb, int l > { > struct mbuf *m, *next, *mfree; >=20 > + KASSERT(len > 0, ("%s: len is %d but it is supposed to be +ve", > + __func__, len)); > + KASSERT(len <=3D sb->sb_ccc, ("%s: len: %d is > ccc: %u", > + __func__, len, sb->sb_ccc)); > + > next =3D (m =3D sb->sb_mb) ? m->m_nextpkt : 0; > mfree =3D NULL; The KASSERT is bad =E2=80=94 please fix it. =46rom = https://ci.freebsd.org/job/FreeBSD-head-amd64-test/1994/console : add host 127.0.0.1panic: sbcut_internal: len is 0 but it is supposed to = be +ve --Apple-Mail=_EC34DEF2-B0E7-49DF-9080-3BD8406A1988 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYviQ5AAoJEPWDqSZpMIYVeYUQALIxYiXbyF61wxGb1r7weTnV Sa3SIHJH5hB/V93SH6kBrRNySSn5wjIl189Y+monm/lf7klVrC4XKCLTMz3o+rOp EzPVQ8Ept2VZlh83T6jFOOsrLSXpla4la/duuE26EFKJKQ2x6aVG3U9JUeNOyQnB db4yPl8Sxzn9FdOR8O5KU5TCh7i3uABD+kjWVpio9afUSsuuZ/OdPeg5mkNlihSO XoZYENxuh6gYeet/6rM1Z13qGEE2/pY1qaIcXFJooapOG8cNH2sjixgGIZsmJ4nq HvuNiZzMIQD9MJ2Nr79M4Wjs1+PwlfNGUuCoKjtjouUTJCpMbIysmRezFf+5ywuF QWv9al5Nm3vaqZGnA5WTtbpp9NGFwa1dgxrStt6vbaGpaJ49WGh+XySvgAkcH7mu 7rvtFhyBDWkUWyaFKLpCHKRyTwSXQYVeu24k+wiRxgZfjYAj9fZxVZJdu8d8x4gR bArHETl0s/EoEiPM0BMFjajj2gOLoWdb7/EZyR6oZO0Eq4gIFlXXCbQtvBysjhxx S5NOdfmh6LBXluiogCr+dU3vuRNAvKJIaT7LNG7kB1uxjnDNg+3MTDehExuW6OEx Fpzmh/0qdLyDljBk5hrZasws9ia0ekZsGtWVb4w4vp1XrvanOeaaYpg2WZydX4dD 9x7o/8Kb2NGF1gDxYmsJ =uFEH -----END PGP SIGNATURE----- --Apple-Mail=_EC34DEF2-B0E7-49DF-9080-3BD8406A1988--