From owner-svn-src-all@freebsd.org Tue Feb 12 02:07:46 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5B80714EFEA2; Tue, 12 Feb 2019 02:07:46 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: from mail-it1-f181.google.com (mail-it1-f181.google.com [209.85.166.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7C1CF97280; Tue, 12 Feb 2019 02:07:45 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: by mail-it1-f181.google.com with SMTP id r11so3466946itc.2; Mon, 11 Feb 2019 18:07:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X+6qFmx1/3cLEmCSo5vMIrBwIVdqeuiZQEmPafmK5jw=; b=JOv14PNheO8doHELB8S7Iwfl6d5BPBNGeGSUIxp+X3SVG6PL5hxoZtqh9XhG/V1kNH 1p5xQ/Ci7wOcRXYuLqZypKyoTfAAbOfk8qrwhzTJyb13Obwven2VsUt4ZFqP7+FwMfsC NZINw5rSsgXxBhdiO5kTEqTCK/o1hobx/JZ9Rht6B9UZOIE4CG4aMUZ5AntTF2xjnEtI mmkwK3yBe7sXO3T5n9S3+yJhRHG81+vcF3+RWQWTWRZEww4rD8Jn1P+5PizoSlPuy4js kn2gp4Q/SMgDW2Iwr3E3WBQmQMgwZeNWMSMMLFX14aGmxYA8QvafRZka90gE/tGgQ3JR RA2w== X-Gm-Message-State: AHQUAuamC3PNaIeZ3Kj6stsKTCN0v48KuaQGpqxhOEnXtIWB3Cv+42i1 0mZTEJAGIlyNXLUI61G0BTY+sFpx424cbpM/pq6LQg== X-Google-Smtp-Source: AHgI3IaYCZh349yG0nDHgMrk+9Wwnk+QnGEEuitz8+5fwtq1lNrkOJeztKR7I9G//q6FEhAH6e6EQIpNWznMBlLBuj8= X-Received: by 2002:a24:2104:: with SMTP id e4mr610002ita.59.1549937259110; Mon, 11 Feb 2019 18:07:39 -0800 (PST) MIME-Version: 1.0 References: <201902120026.x1C0Q1FW073337@pdx.rh.CN85.dnsmgr.net> <62d2dcc1-5bde-1eda-6d9f-82138932cb36@FreeBSD.org> In-Reply-To: From: Patrick Kelsey Date: Mon, 11 Feb 2019 21:07:26 -0500 Message-ID: Subject: Re: svn commit: r344027 - in stable/12/sys: dev/vmware/vmxnet3 modules/vmware/vmxnet3 net To: John Baldwin Cc: rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org X-Rspamd-Queue-Id: 7C1CF97280 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.88 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.994,0]; NEURAL_HAM_SHORT(-0.89)[-0.887,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 02:07:46 -0000 On Mon, Feb 11, 2019 at 8:13 PM Patrick Kelsey wrote: > > > On Mon, Feb 11, 2019 at 8:08 PM John Baldwin wrote: > >> On 2/11/19 4:26 PM, Rodney W. Grimes wrote: >> >> Author: pkelsey >> >> Date: Mon Feb 11 23:24:39 2019 >> >> New Revision: 344027 >> >> URL: https://svnweb.freebsd.org/changeset/base/344027 >> >> >> >> Log: >> >> MFC r343291: >> >> Convert vmx(4) to being an iflib driver. >> > >> > I strongly object to this MFC, given the current number >> > of 12.0 RELEASE related iflib problems we have it is >> > foolish of us to iflib any more drivers in 12.0 >> >> This isn't the release branch though and presumably we have some time >> before >> 12.1 ships. If there are reports of vmx(4) breakage on stable before 12.1 >> we could always revert this commit then? >> >> I've heard of some EN's for 12.0 for iflib fixes. Are those fixes in >> stable/12 >> yet or are we still waiting for them to land in HEAD and/or be merged? >> > > iflib.c is currently the same between head and stable/12. I've found and > fixed a number of iflib bugs by developing the iflib version of the vmx(4) > driver, and it's also being fielded in a product. I'm also aware that not > all current driver problems are necessarily iflib problems. I think we'd > be better off letting this version of vmx(4) ride it out in stable/12 until > such time as we discover an actual horror that we then feel we need to > react to in some way other than just going ahead and fixing it. > > John, Which is to say, I second your motion to proceed with normal process. As one would reasonably expect, this driver didn't fall out of the sky yesterday. It was completed on 15 November 2018 and has been undergoing multi-party testing since then. I doubt it's bug free (nor was the last one), but when bugs have turned up in the driver or in iflib at any point along the way, convergence to root cause and a fix has been same-day, so I don't think there's anything that walks like an emergency or quacks like an emergency related to this commit. -Patrick