From owner-freebsd-net Tue Dec 12 11:48:13 2000 From owner-freebsd-net@FreeBSD.ORG Tue Dec 12 11:48:11 2000 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by hub.freebsd.org (Postfix) with ESMTP id 478BB37B400; Tue, 12 Dec 2000 11:48:11 -0800 (PST) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id eBCJmBf20037; Tue, 12 Dec 2000 11:48:11 -0800 (PST) Date: Tue, 12 Dec 2000 11:48:11 -0800 From: Alfred Perlstein To: John Baldwin Cc: jasone@FreeBSD.org, net@FreeBSD.org, Bosko Milekic Subject: Re: MEXT_IS_REF broken. Message-ID: <20001212114810.H16205@fw.wintelcom.net> References: <20001212014429.Y16205@fw.wintelcom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from jhb@FreeBSD.org on Tue, Dec 12, 2000 at 08:39:27AM -0800 Sender: bright@fw.wintelcom.net Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org * John Baldwin [001212 08:39] wrote: > > On 12-Dec-00 Alfred Perlstein wrote: > > grr... > > > > considering this: > > > >#define MEXT_IS_REF(m) ((m)->m_ext.ref_cnt->refcnt > 1) > > > >#define MEXT_REM_REF(m) do { \ > > KASSERT((m)->m_ext.ref_cnt->refcnt > 0, ("m_ext refcnt < 0")); \ > > atomic_subtract_long(&((m)->m_ext.ref_cnt->refcnt), 1); \ > > } while(0) > > > > this: > > > >#define MEXTFREE(m) do { \ > > struct mbuf *_mmm = (m); \ > > \ > > if (MEXT_IS_REF(_mmm)) \ > > MEXT_REM_REF(_mmm); \ > > > > > > is not mpsafe. we _NEED_ some type that allows atomic dec and test > > for 0. > > http://www.FreeBSD.org/~jhb/patches/refcount.patch You do have a commit bit if I'm not mistaken. :) -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] "I have the heart of a child; I keep it in a jar on my desk." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message