From owner-svn-src-head@FreeBSD.ORG Thu Oct 28 18:25:58 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7B15A106566C; Thu, 28 Oct 2010 18:25:58 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id BC8F88FC14; Thu, 28 Oct 2010 18:25:57 +0000 (UTC) Received: by ywh2 with SMTP id 2so944866ywh.13 for ; Thu, 28 Oct 2010 11:25:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=USqmfz5pyg4LRhfjlRX/iFtf1NkV6+htDtwxH4Aa2r8=; b=ANEr67uGaOrmNnBEf6FR7SnPm8GD0I0QvrXTP3C/JuVNu1lFggfW7SkD4alc+Oggwa PMSoDELb4erchPMjTjTUeDX76Nh4BTxxbRBrqmvRsd59lEmR1i0Oi52K0/o71sK0YUz2 rsntpB9xmP12c1uPqHjycCfv8QrBwdoI5CGdc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=gQn906XuvC5DvjF6sA/vmy8TC3xe7aPKdjdyvDbJFgg73MmL6PueGIEObOE4hmZqDh vhQrdm9GH3Fm0I64m+ex4cgZe7X9e+QD+DO/4hQsGkeM/X4jGtstkwvlCixQD/EsH4e+ TV36bPOJKR7FOknJxCW9+MsVzBKVQ0Tu2N/Eo= MIME-Version: 1.0 Received: by 10.90.2.20 with SMTP id 20mr3194500agb.69.1288290357129; Thu, 28 Oct 2010 11:25:57 -0700 (PDT) Sender: yanegomi@gmail.com Received: by 10.90.70.19 with HTTP; Thu, 28 Oct 2010 11:25:57 -0700 (PDT) In-Reply-To: <4CC9483C.7050507@freebsd.org> References: <201010270232.o9R2Wsu3084553@svn.freebsd.org> <4CC803A8.3040602@freebsd.org> <20101027082122.GD1848@garage.freebsd.pl> <4CC85552.2020100@freebsd.org> <20101027133307.GQ2392@deviant.kiev.zoral.com.ua> <4CC851CC.80509@freebsd.org> <4CC9483C.7050507@freebsd.org> Date: Thu, 28 Oct 2010 11:25:57 -0700 X-Google-Sender-Auth: -ipgJtTNOwM53RqE-A2F3pPkK8A Message-ID: From: Garrett Cooper To: David Xu Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: src-committers@freebsd.org, Pawel Jakub Dawidek , svn-src-all@freebsd.org, Andriy Gapon , svn-src-head@freebsd.org, Kostik Belousov Subject: Re: svn commit: r214409 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Oct 2010 18:25:58 -0000 On Thu, Oct 28, 2010 at 2:54 AM, David Xu wrote: > Garrett Cooper wrote: >> >> On Wed, Oct 27, 2010 at 9:22 AM, Andriy Gapon wrote: >>> >>> [patch attachment was lost] >> >> Ugh... Mailman hates me I guess :(... >> >>> on 27/10/2010 19:07 Garrett Cooper said the following: >>>> >>>> =A0 =A0How about this patch? I implemented this as a readonly tunable = and >>> >>> I don't think that it's correct to call it a tunable or use >>> CTLFLAG_RDTUN. >>> As I understand it is a read-only sysctl. >> >> Converted to CTLFLAG_RD. >> >>>> sysconf tunable, because (AFAIK) the value that is being tested >>>> shouldn't change during runtime after the system has been booted up, >>>> and figuring that the value wasn't going to change it was better to >>>> lose 4/8 bytes on the kernel stack instead of having to recompute the >>>> value every time in a function call, with the associated lost heap / >>>> stack memory in the process, as the assumption is that this libcall >>>> was going to be called frequently by some programs. > > The patch looks fine to me. ;-) If no one opposes the change, could you please commit the patch for me Davi= d? Thanks! -Garrett