From owner-svn-src-head@freebsd.org Tue Feb 28 22:09:33 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6363CCF13A3; Tue, 28 Feb 2017 22:09:33 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0463C64F; Tue, 28 Feb 2017 22:09:32 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-wr0-f175.google.com with SMTP id g10so18026717wrg.2; Tue, 28 Feb 2017 14:09:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=YXmYtCjG+mYe96kcVzXR28Qabwo34D5yNekZZZQdvMI=; b=k9bQkGX+GEvaGFvWTRKwgEldNfVTc50vLhfDWBDFHLGbAKhkpUQwu+Ol5gL6bdpF1W k5yNj7K4goBAc0uf9DTmYRxruRtBNUK6H0WL7owycZ/kTnyAN28YUiiskmTHiUkprjTa 3TtrJak6fq/jZk2XGnhyJ9tcxrER3XPOIvndd7NZRNHjrOeShnzVayygqpzeHVF8e5x5 EucyxOvA2klMSDDrOHfKxiEtKAxVfk1nIfYkd7wmgt9hTwaeba46FuIqvN2n972tZFN/ VTXRjZ5SSP9NtRKF93Tnp9rP5m5FRSlT30HljUvVlxgd+R//xzK6wAjBVfjYR1JQrLbU sR5w== X-Gm-Message-State: AMke39lvHAKmOS8zIJQsIkXawhbA0vFChmfFvP/nGOFvWHGXt3GXjCJiRnfbUcgejDMo9A== X-Received: by 10.223.155.193 with SMTP id e1mr3778191wrc.86.1488319365021; Tue, 28 Feb 2017 14:02:45 -0800 (PST) Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com. [209.85.128.174]) by smtp.gmail.com with ESMTPSA id 63sm2636438wmp.9.2017.02.28.14.02.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Feb 2017 14:02:44 -0800 (PST) Received: by mail-wr0-f174.google.com with SMTP id l37so17918190wrc.1; Tue, 28 Feb 2017 14:02:44 -0800 (PST) X-Received: by 10.223.146.131 with SMTP id 3mr4472818wrn.198.1488319364764; Tue, 28 Feb 2017 14:02:44 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.80.152.82 with HTTP; Tue, 28 Feb 2017 14:02:44 -0800 (PST) In-Reply-To: <201702282127.v1SLRqDH048319@repo.freebsd.org> References: <201702282127.v1SLRqDH048319@repo.freebsd.org> From: Conrad Meyer Date: Tue, 28 Feb 2017 14:02:44 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r314420 - head/sys/kern To: Scott Long Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 22:09:33 -0000 On Tue, Feb 28, 2017 at 1:27 PM, Scott Long wrote: > Author: scottl > Date: Tue Feb 28 21:27:51 2017 > New Revision: 314420 > URL: https://svnweb.freebsd.org/changeset/base/314420 > > Log: > Provide a comment on why stdio.h needs to be included. > > Modified: > head/sys/kern/subr_prf.c > > Modified: head/sys/kern/subr_prf.c > ============================================================================== > --- head/sys/kern/subr_prf.c Tue Feb 28 21:18:45 2017 (r314419) > +++ head/sys/kern/subr_prf.c Tue Feb 28 21:27:51 2017 (r314420) > @@ -76,6 +76,13 @@ __FBSDID("$FreeBSD$"); > #include > #else > #include > +#endif > + > +/* > + * This is needed for sbuf_putbuf() when compiled into userland. Due to the > + * shared nature of this file, it's the only place to put it. Couldn't it go in the #else clause above? Best, Conrad