Date: Tue, 22 Jan 2019 21:34:22 +0100 From: Jan Beich <jbeich@FreeBSD.org> To: Christoph Moench-Tegeder <cmt@burggraben.net> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r490910 - in head: Mk Mk/Uses mail/thunderbird www/firefox www/firefox-esr www/firefox-i18n www/firefox/files www/palemoon www/seamonkey Message-ID: <d0oo-fn3l-wny@FreeBSD.org> References: <201901212303.x0LN3jR3059519@repo.freebsd.org> <CAGBxaX=T7SvB6Ncm-0Drt1-HLED92xKuJ-LRvg%2BYsDFKrYCp4A@mail.gmail.com> <CAGBxaXmOibxw_q5Ev34oyiCetNRqNVLNY5VjQrJZFEFTy6nDhg@mail.gmail.com> <o989-8nt8-wny@FreeBSD.org> <20190122100911.GA77378@elch.exwg.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Christoph Moench-Tegeder <cmt@burggraben.net> writes: > Excuse my hijacking of this thread... > > firefox 65 fails to build (poudirere, amd64, 12.0) when option WAYLAND > is disabled (that't not the default), first error is: > > : In file included from /wrkdirs/usr/ports/www/firefox/work/.build/gfx/webrender_bindings/Unified_cpp_webrender_bindings0.cpp:20: > : > /wrkdirs/usr/ports/www/firefox/work/firefox-65.0/gfx/webrender_bindings/RenderCompositor.cpp:35:47: > error: use of undeclared identifier 'RenderCompositorEGL'; did you > mean 'RenderCompositorOGL'? > : UniquePtr<RenderCompositor> eglCompositor = RenderCompositorEGL::Create(aWidget); > : ^~~~~~~~~~~~~~~~~~~ > : RenderCompositorOGL > > Looking at patch-bug1514156 with perfect hindsight, that's somewhat > obvious as the include of RenderCompositorEGL.h is guarded with an > #ifdef MOZ_WAYLAND (line 20 of RenderCompositor.cpp), but the first use > of RenderCompositorEGL (line 35, see above) is wrapped in an #ifdef > MOZ_WIDGET_GTK. Looking at Try options[1] and automation[2] I'm not sure WAYLAND=off is tested nowadays. In www/firefox WAYLAND=off has no effect[3] unless x11-toolkits/gtk30 also has WAYLAND=off. I've reported the issue upstream[4] but for now just locally remove files/patch-bug1514156. If there's no fix in sight after actual release on 2019-01-29 then the patch can be moved under WAYLAND_EXTRA_PATCHES. [1] https://mozilla-releng.net/trychooser/ [2] https://treeherder.mozilla.org/ [3] https://bugzilla.mozilla.org/show_bug.cgi?id=1501218 [4] https://bugzilla.mozilla.org/show_bug.cgi?id=1514156#c26
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d0oo-fn3l-wny>