From owner-freebsd-current Sun Mar 10 13:27:52 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id NAA20774 for current-outgoing; Sun, 10 Mar 1996 13:27:52 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id NAA20766 for ; Sun, 10 Mar 1996 13:27:48 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.12/8.6.9) id IAA15692; Mon, 11 Mar 1996 08:24:51 +1100 Date: Mon, 11 Mar 1996 08:24:51 +1100 From: Bruce Evans Message-Id: <199603102124.IAA15692@godzilla.zeta.org.au> To: bde@zeta.org.au, wosch@cs.tu-berlin.de Subject: Re: *.mk wishes Cc: current@FreeBSD.org Sender: owner-current@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk >20 programs which use mmap(2) >3 (gnu) programs with C macro HAVE_MMAP or HAVE_WORKING_MMAP I only found 2 :-) (gdb and groff). They are apparently too old and/or complicated to use autoconf and haven't been configured quite right for FreeBSD (unless mmap was avoided on purpose). >5 programs with PROT_WRITE >21 mmap calls with uncasted 'NULL' argument >Ok, we don't need a variable in sys.mk for 3 programs only. We should >fix the cast ... newfs/mkfs.c passes an uncast 0 for a pointer and an uncast 0 for an off_t. rpc.statd passes an uncast NULL for a pointer and an uncast 0 for an off_t. I would't worry about fixing this. There must be a prototype in scope for the uncast 0 for an off_t to work, and it isn't a bug to omit the casts iff there is a prototype in scope. Just fix the configuration. Do we have a working mmap? :-) Bruce