Date: Mon, 18 Jun 2012 16:24:24 -0700
From: Jason Helfman <jgh@FreeBSD.org>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc: nsand@sura.ru
Subject: ports/169215: [PATCH] net/skyfish: fix usage of ${SRC_BASE} before it is defined
Message-ID: <1340061864.584927.2424.nullmailer@experts-exchange.com>
Resent-Message-ID: <201206182330.q5INUI6f015247@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 169215
>Category: ports
>Synopsis: [PATCH] net/skyfish: fix usage of ${SRC_BASE} before it is defined
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Jun 18 23:30:18 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Jason Helfman
>Release: FreeBSD 8.3-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.3-RELEASE FreeBSD 8.3-RELEASE #0: Mon Apr 9 21:23:18 UTC
>Description:
Original PR filed as ports/165994
SRC_BASE is being used before being defined in several ports. it happened to
work anyways in most cases because the main use of SRC_BASE is for checking if
${SRC_BASE}/sys/ (/usr/src/sys/) exists, and if SRC_BASE is empty, it just
checks for /sys/ which does exist on most systems as a symlink to /usr/src/sys/.
Port maintainer (nsand@sura.ru) is cc'd.
Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:
--- skyfish-0.91.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/net/skyfish/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- Makefile 26 Aug 2009 04:40:46 -0000 1.4
+++ Makefile 18 Jun 2012 23:25:32 -0000
@@ -13,6 +13,8 @@
MAINTAINER= nsand@sura.ru
COMMENT= Grabbing TCP streams from network interface (SAT internet)
+.include <bsd.port.pre.mk>
+
SYSDIR?= ${SRC_BASE}/sys
KMODDIR= /boot/modules
PLIST_SUB+= KMODDIR=${KMODDIR}
@@ -28,4 +30,4 @@
exit 1
.endif
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
--- skyfish-0.91.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1340061864.584927.2424.nullmailer>