From owner-cvs-sys Sat Mar 18 00:45:54 1995 Return-Path: cvs-sys-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id AAA23974 for cvs-sys-outgoing; Sat, 18 Mar 1995 00:45:54 -0800 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id AAA23958; Sat, 18 Mar 1995 00:45:48 -0800 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.8/8.6.6) id AAA20825; Sat, 18 Mar 1995 00:44:05 -0800 From: "Rodney W. Grimes" Message-Id: <199503180844.AAA20825@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/sys/libkern locc.c random.c scanc.c skpc.c libkern To: bde@zeta.org.au (Bruce Evans) Date: Sat, 18 Mar 1995 00:44:05 -0800 (PST) Cc: davidg@Root.COM, phk@ref.tfs.com, CVS-commiters@freefall.cdrom.com, cvs-sys@freefall.cdrom.com In-Reply-To: <199503180835.SAA13231@godzilla.zeta.org.au> from "Bruce Evans" at Mar 18, 95 06:35:29 pm X-Mailer: ELM [version 2.4 PL23] Content-Type: text Content-Length: 1239 Sender: cvs-sys-owner@freebsd.org Precedence: bulk > > >>> We install , it referenced which > >>> wasn't there (unless you have sources installed). this is wrong. > >>> > >>> An alternative solution might be: "#ifdef KERNEL" around the include. > > No, shouldn't be included by non-kernel code at all. And my grepping of the source tree turned up no one that directly inclues sys/systm.h, but it *is* included by vm_page.h. I have yet to search the source tree for that one. This does bring up the question of should we be installing all the files we are in /usr/include/sys. As I am about to rewrite the /usr/include Makefile to clean up all the mkdir/chown/chmod this would be a *very* good time to clean up *exactly* what header files we install into /usr/include/sys. > >>Not as long as we install /usr/lib/libkern.a then we simply need to > >>install libkern.h as well. > > > We shouldn't install libkern.a. > > I agree. If no one objects by tomarrow afternoon we will not be installing libkern* in /usr/lib. This is just a waste of (albiet it small) disk space. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD