Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 20 Aug 2013 13:58:31 +0200
From:      John Marino <freebsd.contact@marino.st>
To:        Andrej Zverev <az@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r325041 - head/japanese/eb
Message-ID:  <521359E7.2020008@marino.st>
In-Reply-To: <201308201148.r7KBmYcU083251@svn.freebsd.org>
References:  <201308201148.r7KBmYcU083251@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 8/20/2013 13:48, Andrej Zverev wrote:
> Author: az
> Date: Tue Aug 20 11:48:33 2013
> New Revision: 325041
> URL: http://svnweb.freebsd.org/changeset/ports/325041
> 
> Log:
>   - Conver to new perl5 framework.
>   - Remove duplication of 'USES=gettext'.

> Modified: head/japanese/eb/Makefile
> ==============================================================================
> --- head/japanese/eb/Makefile	Tue Aug 20 11:43:44 2013	(r325040)
> +++ head/japanese/eb/Makefile	Tue Aug 20 11:48:33 2013	(r325041)
> @@ -65,8 +65,7 @@ PORTDOCS=	eb-01.html eb-02.html eb-03.ht
>  
>  USE_AUTOTOOLS=	libtool
>  USE_BZIP2=	yes
> -USES=		gettext
> -USE_PERL5=	yes
> +USES=		gettext perl5
>  GNU_CONFIGURE=	yes
>  USE_LDCONFIG=	yes
>  CONFIGURE_ARGS=	--with-pkgdocdir=${DOCSDIR}
> @@ -78,7 +77,6 @@ APPENDIXDIR=	${DATADIR}/appendix
>  .include <bsd.port.options.mk>
>  
>  .if ${PORT_OPTIONS:MNLS}
> -USES+=		gettext
>  CONFIGURE_ARGS+=	--enable-nls \
>  		--with-gettext-includes=${LOCALBASE}/include \
>  		--with-gettext-libraries=${LOCALBASE}/lib \
> 

Andrej,

I think you fixed gettext usage incorrectly.
>From this diff, you should not have removed USES+= gettext from the NLS
options.

You should have removed USES=gettext on line 68 though.
It's used conditionally.  If you don't have NLS option set on, you don't
need gettext.

Regards,
John



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?521359E7.2020008>