From owner-cvs-all Thu Sep 27 16:45:38 2001 Delivered-To: cvs-all@freebsd.org Received: from InterJet.elischer.org (c421509-a.pinol1.sfba.home.com [24.7.86.9]) by hub.freebsd.org (Postfix) with ESMTP id C32D437B422; Thu, 27 Sep 2001 16:44:41 -0700 (PDT) Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id RAA67512; Thu, 27 Sep 2001 17:34:49 -0700 (PDT) Date: Thu, 27 Sep 2001 17:34:49 -0700 (PDT) From: Julian Elischer To: Warner Losh Cc: obrien@FreeBSD.org, julian@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys proc.h In-Reply-To: <200109272315.f8RNFI776885@harmony.village.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG the patches were available for testing for nearly 3 weeks and NOBODY mentionned this.. I have no objection to it on principle but I don't want to see people doing: #define proc thread int blah(struct proc *p) { foo(p); } talk about obscuring the code!!! and why d_threat_t? is is part of the devsw definition? (d_open_t, d_write_t) On Thu, 27 Sep 2001, Warner Losh wrote: > In message <20010927135919.A80580@dragon.nuxi.com> "David O'Brien" writes: > : !!128!! style(9) breakages?? Uh, Julian we do have standards around here. > : Why could you not follow them? You seem to have gone out of your way to > : change existing correct style. Obviously we need to scrutinize your > : commits more. > > I'm still rather grumpy about the struct thread API change to all > drivers. I'm thinking of creating a d_thread_t typedef that's right > for both stable and current... > > warner > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message