From owner-svn-src-head@freebsd.org  Thu Oct  5 12:25:19 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AE620E37472;
 Thu,  5 Oct 2017 12:25:19 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7D6DB6EF0D;
 Thu,  5 Oct 2017 12:25:19 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v95CPI9x040071;
 Thu, 5 Oct 2017 12:25:18 GMT (envelope-from avg@FreeBSD.org)
Received: (from avg@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id v95CPIdM040070;
 Thu, 5 Oct 2017 12:25:18 GMT (envelope-from avg@FreeBSD.org)
Message-Id: <201710051225.v95CPIdM040070@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: avg set sender to avg@FreeBSD.org
 using -f
From: Andriy Gapon <avg@FreeBSD.org>
Date: Thu, 5 Oct 2017 12:25:18 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r324309 - head/sys/cddl/compat/opensolaris/kern
X-SVN-Group: head
X-SVN-Commit-Author: avg
X-SVN-Commit-Paths: head/sys/cddl/compat/opensolaris/kern
X-SVN-Commit-Revision: 324309
X-SVN-Commit-Repository: base
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Oct 2017 12:25:19 -0000

Author: avg
Date: Thu Oct  5 12:25:18 2017
New Revision: 324309
URL: https://svnweb.freebsd.org/changeset/base/324309

Log:
  remove heuristic error detection from ddi_strto*()
  
  Zero, <TYPE>_MIN and <TYPE>_MAX values can result from valid conversions.
  They don't necessarily imply any error.
  Since we do not have any reliable error signaling from libkern's strto*(),
  it's better to always assume success rather than to report an error when
  there is none.
  
  Reviewed by:	tsoome
  MFC after:	2 weeks
  Differential Revision: https://reviews.freebsd.org/D12565

Modified:
  head/sys/cddl/compat/opensolaris/kern/opensolaris_sunddi.c

Modified: head/sys/cddl/compat/opensolaris/kern/opensolaris_sunddi.c
==============================================================================
--- head/sys/cddl/compat/opensolaris/kern/opensolaris_sunddi.c	Thu Oct  5 12:19:55 2017	(r324308)
+++ head/sys/cddl/compat/opensolaris/kern/opensolaris_sunddi.c	Thu Oct  5 12:25:18 2017	(r324309)
@@ -41,10 +41,6 @@ ddi_strtol(const char *str, char **nptr, int base, lon
 {
 
 	*result = strtol(str, nptr, base);
-	if (*result == 0)
-		return (EINVAL);
-	else if (*result == LONG_MIN || *result == LONG_MAX)
-		return (ERANGE);
 	return (0);
 }
 
@@ -58,10 +54,6 @@ ddi_strtoul(const char *str, char **nptr, int base, un
 	}
 
 	*result = strtoul(str, nptr, base);
-	if (*result == 0)
-		return (EINVAL);
-	else if (*result == ULONG_MAX)
-		return (ERANGE);
 	return (0);
 }
 
@@ -70,10 +62,6 @@ ddi_strtoull(const char *str, char **nptr, int base, u
 {
 
 	*result = (unsigned long long)strtouq(str, nptr, base);
-	if (*result == 0)
-		return (EINVAL);
-	else if (*result == ULLONG_MAX)
-		return (ERANGE);
 	return (0);
 }