From owner-freebsd-bugs@FreeBSD.ORG  Sat Jan 24 10:20:19 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 80B9316A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 24 Jan 2004 10:20:19 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3CE0043D5C
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 24 Jan 2004 10:20:09 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	i0OIK9FR014627	for <freebsd-bugs@freefall.freebsd.org>;
	Sat, 24 Jan 2004 10:20:09 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i0OIK95k014626;
	Sat, 24 Jan 2004 10:20:09 -0800 (PST)
	(envelope-from gnats)
Resent-Date: Sat, 24 Jan 2004 10:20:09 -0800 (PST)
Resent-Message-Id: <200401241820.i0OIK95k014626@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Eugene Grosbein <eugen@grosbein.pp.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 47B2616A4CE
	for <FreeBSD-gnats-submit@freebsd.org>;
	Sat, 24 Jan 2004 10:18:18 -0800 (PST)
Received: from grosbein.pp.ru (grgw.svzserv.kemerovo.su [213.184.64.130])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5403043D5C
	for <FreeBSD-gnats-submit@freebsd.org>;
	Sat, 24 Jan 2004 10:17:57 -0800 (PST)
	(envelope-from eugen@grosbein.pp.ru)
Received: from grosbein.pp.ru (eugen@localhost [127.0.0.1])
	by grosbein.pp.ru (8.12.10/8.12.10) with ESMTP id i0OIHsoY010902
	for <FreeBSD-gnats-submit@freebsd.org>;
	Sun, 25 Jan 2004 01:17:54 +0700 (KRAT)
	(envelope-from eugen@grosbein.pp.ru)
Received: (from eugen@localhost)
	by grosbein.pp.ru (8.12.10/8.12.10/Submit) id i0OIHsFE010901;
	Sun, 25 Jan 2004 01:17:54 +0700 (KRAT)
	(envelope-from eugen)
Message-Id: <200401241817.i0OIHsFE010901@grosbein.pp.ru>
Date: Sun, 25 Jan 2004 01:17:54 +0700 (KRAT)
From: Eugene Grosbein <eugen@grosbein.pp.ru>
To: FreeBSD-gnats-submit@FreeBSD.org
X-Send-Pr-Version: 3.113
Subject: bin/61846: [PATCH] cosmetic off-by-one error in ipfw2 leads to
	SIGSEGV
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Eugene Grosbein <eugen@grosbein.pp.ru>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Jan 2004 18:20:19 -0000


>Number:         61846
>Category:       bin
>Synopsis:       [PATCH] cosmetic off-by-one error in ipfw2 leads to SIGSEGV
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 24 10:20:08 PST 2004
>Closed-Date:
>Last-Modified:
>Originator:     Eugene Grosbein
>Release:        FreeBSD 4.9-STABLE i386
>Organization:
Svyaz Service JSC
>Environment:
System: FreeBSD grosbein.pp.ru 4.9-STABLE FreeBSD 4.9-STABLE #8: Sun Dec 14 20:25:57 KRAT 2003 eu@grosbein.pp.ru:/usr/local/obj/usr/local/src/sys/DADV i386

>Description:

	ipfw2 can segfault when is run with incorrect parameters

>How-To-Repeat:

	ipfw pipe 1 config 1Kbyte/s

>Fix:

--- ipfw2.c.orig	Sun Jan 25 01:12:53 2004
+++ ipfw2.c	Sun Jan 25 01:14:16 2004
@@ -2413,7 +2413,7 @@
 			break;
 
 		default:
-			errx(EX_DATAERR, "unrecognised option ``%s''", *av);
+			errx(EX_DATAERR, "unrecognised option ``%s''", av[-1]);
 		}
 	}
 	if (do_pipe == 1) {


>Release-Note:
>Audit-Trail:
>Unformatted: