Date: Wed, 01 Apr 2015 00:46:34 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 199052] [PATCH] Use 7 alphanumeric GH_COMMIT for WRKSRC, related to "legacy.tar.gz" (codeload) GitHub backend method Message-ID: <bug-199052-13-2z46m7XPEd@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-199052-13@https.bugs.freebsd.org/bugzilla/> References: <bug-199052-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199052 --- Comment #2 from lightside <lightside@gmx.com> --- (In reply to Bryan Drewery from comment #1) > I don't see any reason to change GH_COMMIT. Really? This is not surprising, because you are the person, who committed related changes. (In reply to Bryan Drewery from comment #1) > Please convert ports using it. I already submitted related PRs. Some of the ports has a benefit, because they may use available tags, but some not, if there is a need to use full commit hash, i.e. very long directory name for WRKSRC. Overall, this is just a not needed (untimely) switch from one workable solution (legacy.tar.gz) to another (tar.gz), in my opinion. There was a possibility to use tags with proper changes, without the need to convert other ports. The one of the reasons to convert was a not supported longer abbreviated (or full) commit hash for GH_COMMIT method, which is wrong. But I agree, that this PR may be too late. There are other changes and public statements, which prevents it. Feel free to close this PR, if you don't need proposed changes. At least, there are no other expressed opinions here to this moment. -- You are receiving this mail because: You are on the CC list for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-199052-13-2z46m7XPEd>