Date: Tue, 15 Aug 2006 12:34:41 +0400 From: Ruslan Ermilov <ru@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Dag-Erling Smorgrav <des@FreeBSD.org> Subject: Re: cvs commit: src/sys/conf kern.post.mk kmod.mk src/sys/modules/if_ef Makefile src/sys/modules/if_ppp Makefile src/sys/modules/netgraph/mppc Makefile src/sys/modules/sound/sound Makefile Message-ID: <20060815083441.GD67570@rambler-co.ru> In-Reply-To: <20060815085001.S32503@delplex.bde.org> References: <200608141328.k7EDSrRB084019@repoman.freebsd.org> <20060815085001.S32503@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--EY/WZ/HvNxOox07X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Bruce, On Tue, Aug 15, 2006 at 09:40:36AM +1000, Bruce Evans wrote: > On Mon, 14 Aug 2006, Dag-Erling Smorgrav wrote: >=20 > >des 2006-08-14 13:28:53 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/conf kern.post.mk kmod.mk > > sys/modules/if_ef Makefile > > sys/modules/if_ppp Makefile > > sys/modules/netgraph/mppc Makefile > > sys/modules/sound/sound Makefile > > Log: > > Don't use touch when what is really meant is :> (create an empty file, = or > > truncate it if it exists) or :>> (ensure the file exists, but don't cha= nge > > it if it already does) >=20 > Why not just ">" or ">>"? >=20 > > Reviewed by: ru > > MFC after: 2 weeks > > > > Revision Changes Path > > 1.96 +1 -1 src/sys/conf/kern.post.mk > > 1.210 +2 -2 src/sys/conf/kmod.mk > > 1.14 +4 -4 src/sys/modules/if_ef/Makefile > > 1.36 +3 -3 src/sys/modules/if_ppp/Makefile > > 1.14 +1 -1 src/sys/modules/netgraph/mppc/Makefile > > 1.19 +1 -1 src/sys/modules/sound/sound/Makefile >=20 > I use echo -n for one of these. "echo" is less cryptic than ">", and > is probably faster since /bin/echo is smaller than /bin/sh and is used > enough to keep it cached. >=20 make(1) will still use sh(1) when it sees ">", so what's the point? > In sound/Makefile, the cleanup should be to remove the touching (now > emptying) since the touching used to be just worse than the default of > emptying and is now just the same as the default (but takes extra code). >=20 No. It has a preceding comment explaining why it's needed on sparc64: to always build sound.ko without isadma dependency; see rev. 1.16 by marius@. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --EY/WZ/HvNxOox07X Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFE4YchqRfpzJluFF4RAgzAAJ9ucoajumHyO6R9MVgXKTQMcgUhigCfaq+H BQOwOS1POvMws8ZZGpQHzMU= =Mr0F -----END PGP SIGNATURE----- --EY/WZ/HvNxOox07X--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060815083441.GD67570>