Date: Thu, 20 Oct 2011 14:40:23 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r226552 - head/sys/boot/zfs Message-ID: <4EA008A7.7010203@FreeBSD.org> In-Reply-To: <20111020093552.GF1722@garage.freebsd.pl> References: <201110192340.p9JNebOH047566@svn.freebsd.org> <4E9FCA7D.8010900@FreeBSD.org> <20111020093552.GF1722@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
on 20/10/2011 12:35 Pawel Jakub Dawidek said the following: > On Thu, Oct 20, 2011 at 10:15:09AM +0300, Andriy Gapon wrote: >> I believe that this commit is incorrect. >> It does appear to do the right thing for raidz, but I believe that it breaks the >> simple case when v_read is vdev_read_phys. Now because the bp argument is not >> NULL, the latter will try to read BP_GET_PSIZE(bp) bytes instead of >> SPA_GANGBLOCKSIZE bytes. >> >> I believe that my patch that I shared (much) earlier handles this issue >> correctly and integrally: >> http://article.gmane.org/gmane.os.freebsd.devel.file-systems/13130 >> Did you find anything wrong with it? >> If not, then maybe we can get back to discussing it? > > You see. My memory is very short:) and I remembered that you were > working on gang blocks in ZFS boot code, but could find the commit, so I > went ahead with my changes. Those changes still didn't fix one problem > for me. Your patch seems to be much more complete and correct and it > fixes all my problems. > > Please, wait no longer and commit your patch! We have to have this in 9.0. > Unfortunately, at the moment I can only afford to spend at most 1/2 hour a day for FreeBSD (and those go mostly into reading and writing emails) and my development environment is in a little bit of disarray. I will try to find some time, but if you have a chance to review, possibly rework and commit those changes, that would be really great and appreciated. Thank you! -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EA008A7.7010203>