From owner-freebsd-smp@FreeBSD.ORG Fri Aug 31 09:42:40 2007 Return-Path: Delivered-To: smp@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ED83C16A417 for ; Fri, 31 Aug 2007 09:42:40 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.188]) by mx1.freebsd.org (Postfix) with ESMTP id 8453413C442 for ; Fri, 31 Aug 2007 09:42:40 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by nf-out-0910.google.com with SMTP id k4so626844nfd for ; Fri, 31 Aug 2007 02:42:02 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=VebpFZmqPiGZsC7hwRcM+rcPanmqZw3zow0Q3vr5c+Pm5WTd6KpzPlCqe5gCys53yarTs/UWJ2QeZkZh1i9SeSr2ZgCN4EU81U9NXLooOwVn6VTeTI/FFlMU3FDh116+41FWfkNcAjI0JNyqpL+oNUV7OSBOtmRrUkJYAULwd/Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=YXJhSmdkPMbjtZAPRqi0/WY7hF4c/3OXs597QvF/LiW+yzK/7CiPxUV5w7Cd5rohKwhhUyx04taqp+wSlFXqF4k6atI2mxpz0MKHnm8aY8g28avmu05uw8i3ifBUCrDvE+adZ0GLl0hTTcAEEAPUoCOOYaZCdt6HKPoLAyiRz9w= Received: by 10.78.118.5 with SMTP id q5mr1056017huc.1188551602097; Fri, 31 Aug 2007 02:13:22 -0700 (PDT) Received: by 10.78.97.18 with HTTP; Fri, 31 Aug 2007 02:13:22 -0700 (PDT) Message-ID: <3bbf2fe10708310213o297512e8m86e4bb5eb029bf9b@mail.gmail.com> Date: Fri, 31 Aug 2007 11:13:22 +0200 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "Kris Kennaway" In-Reply-To: <46D7D711.80406@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070831071048.GF87451@elvis.mu.org> <46D7D711.80406@FreeBSD.org> X-Google-Sender-Auth: 7fdf2a7decf47266 Cc: smp@freebsd.org, Alfred Perlstein Subject: Re: request for review: backport of sx and rwlocks from 7.0 to 6-stable X-BeenThere: freebsd-smp@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD SMP implementation group List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2007 09:42:41 -0000 2007/8/31, Kris Kennaway : > Alfred Perlstein wrote: > > Hi guys, > > > > Some work here at work was approved for sharing with community so > > I'm posting it here in hope of a review. > > > > We run some pretty good stress testing on our code, so I think it's > > pretty solid. > > > > My only concern is that I've tried my best to preserve kernel source > > API, but not binary compat though a few simple #defines. > > > > I can make binary compat, in albeit a somewhat confusing manner, but > > that will require some rototilling and weird renaming of calls to > > the sleepq and turnstile code. In short, I'd rather not, but I will > > if you think it's something that should be done. > > > > There's also a few placeholders for lock profiling which I will > > very likely be backporting shortly as well. > > > > Patch is attached. > > > > Comments/questions? > > Hmm, I would be happy to see this but I think binary compatibility is > actually important here since this is -stable and low-level primitives > like sx are probably used all over the place in existing third party > modules. Regarding to this I think that really we could only backport rwlocks as sxlocks want a new ABI. I will try to give a look at it ASAP, btw thanks for the effort! Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein