Date: Tue, 16 Jul 2002 06:35:56 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: "M. Warner Losh" <imp@bsdimp.com> Cc: des@ofug.org, <keramida@FreeBSD.ORG>, <freebsd-audit@FreeBSD.ORG> Subject: Re: bin/ln & WARNS=5 Message-ID: <20020716063117.G41957-100000@gamplex.bde.org> In-Reply-To: <20020715.132802.128242391.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 15 Jul 2002, M. Warner Losh wrote:
> In message: <20020716051814.Q41695-100000@gamplex.bde.org>
> Bruce Evans <bde@zeta.org.au> writes:
> : That is a bug in 7+ kloc. No so very old code like src/bin/ln (together
> : with most of src/bin and large parts of src/{sbin,usr.bin,usr.sbin}
> : was obviously cleaned up to have a common style in 4.4BSD or earlier.
> : Equally obviously, the cleanup didn't get as far as src/games.
>
> So would you agree with:
>
> Index: style.9
> ===================================================================
> RCS file: /cache/ncvs/src/share/man/man9/style.9,v
> retrieving revision 1.87
> diff -u -r1.87 style.9
> --- style.9 2 Jul 2002 01:39:35 -0000 1.87
> +++ style.9 15 Jul 2002 18:15:58 -0000
> @@ -520,6 +520,13 @@
> Note that
> .Xr indent 1
> does not understand this rule.
> +.Ic sizeof Ns 's
> +are written like function calls always.
> +The redundant parenthesis rules do not apply to
> +.Ic sizeof(var)
> +instances.
> +Some code in the tree does not follow the last part of this rule.
> +Do not change it gratuitously to do so.
> .Pp
> .Dv NULL
> is the preferred null pointer constant.
>
OK. One of the many inconsistencies in style.9 was that it says that
casts are "not followed by a space" (so "sizeof foo" is not permitted)
and that parentheses must not be used "unless they are required for
precedence or ..." (so "sizeof foo" is required).
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020716063117.G41957-100000>