From owner-freebsd-stable@FreeBSD.ORG Mon Sep 22 17:28:53 2014 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 17A2A8ED; Mon, 22 Sep 2014 17:28:53 +0000 (UTC) Received: from mailrelay010.isp.belgacom.be (mailrelay010.isp.belgacom.be [195.238.6.177]) by mx1.freebsd.org (Postfix) with ESMTP id 5B1E6A2C; Mon, 22 Sep 2014 17:28:52 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AnIGAC5YIFRR8bfp/2dsb2JhbABggw6BIArSIAGBDRcBeYQEAQEEOhwjEAsOCgklDyoeBhOIQgGyApI9AReQBgeESwEEnRWVU4IegUU7L4JKAQEB Received: from 233.183-241-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.241.183.233]) by relay.skynet.be with ESMTP; 22 Sep 2014 19:28:45 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id s8MHSiHF004814; Mon, 22 Sep 2014 19:28:44 +0200 (CEST) (envelope-from tijl@FreeBSD.org) Date: Mon, 22 Sep 2014 19:28:44 +0200 From: Tijl Coosemans To: Stefan Esser Subject: Re: [patch] syscons/vt keymap: Norwegian country code conflicts with default value Message-ID: <20140922192844.7de1bb6b@kalimero.tijl.coosemans.org> In-Reply-To: <54201192.5080906@freebsd.org> References: <20140921183936.03617590@onyx.thanelange.no> <54201192.5080906@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Gyrd Thane Lange , freebsd-current@freebsd.org, freebsd-stable stable X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Sep 2014 17:28:53 -0000 On Mon, 22 Sep 2014 14:09:54 +0200 Stefan Esser wrote: > Am 21.09.2014 um 18:39 schrieb Gyrd Thane Lange: > > Hi, > > > > Recent changes in keymap namning for syscons/vt to use shorter names > > has exposed a conflict with the value "no" both used as country code > > for Norway and as a default value indicating that no keymap is set. > > > > The attached patch proposes to use "" (empty string) as default value > > instead. > > Hi Gyrd, > > thank you for reporting the issue! > > I have just committed a slightly different patch to -CURRENT and plan > to merge it to 10-STABLE in time for the next BETA. > > You may want to check-out r271958 ... > > > The approach I have chosen it to let "NO" continue to stand for "do > not load any keymap", while "no" is now recognized as equivalent to > "no.kbd". > > > The new semantics of the keymap parameter in rc.conf are: > > keymap='' ==> do not load any keymap (unchanged) > keymap=NO ==> do not load any keymap (unchanged) > keymap=no ==> load Norwegian keymap (new) > > This may still catch people that have edited rc.conf to use "no" in > the meaning "no keymap" by accident, but I see no other approach that > better complies with POLA ... Maybe NONE. It's already being used in a number of cases.