From owner-freebsd-ports Wed Dec 4 3:50: 6 2002 Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1074D37B401 for ; Wed, 4 Dec 2002 03:50:05 -0800 (PST) Received: from heaven.gigo.com (heaven.gigo.com [64.57.102.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5ED6743E4A for ; Wed, 4 Dec 2002 03:50:04 -0800 (PST) (envelope-from lioux@brturbo.com) Received: from 200-193-225-219-bsace7003.dsl.telebrasilia.net.br (200-193-225-219-bsace7003.dsl.telebrasilia.net.br [200.193.225.219]) by heaven.gigo.com (Postfix) with ESMTP id A3478B734 for ; Wed, 4 Dec 2002 03:49:50 -0800 (PST) Received: (qmail 12374 invoked by uid 1001); 4 Dec 2002 11:19:48 -0000 Message-ID: <20021204111948.12373.qmail@exxodus.fedaykin.here> Date: Wed, 4 Dec 2002 09:19:26 -0200 From: Mario Sergio Fujikawa Ferreira To: Kris Kennaway , portmgr@FreeBSD.ORG, ports@FreeBSD.ORG Subject: Re: [PATCH] PTHREAD_CFLAGS/LIBS on sparc64 References: <20021127155317.GG375@straylight.oblivion.bg> <20021203155143.22703.qmail@exxodus.fedaykin.here> <20021203204611.GA38099@rot13.obsecurity.org> <20021204110420.GO365@straylight.oblivion.bg> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20021204110420.GO365@straylight.oblivion.bg> User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 4.7-STABLE X-Disclaimer: I hope you find what you are looking for... in life :) Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Wed, Dec 04, 2002 at 01:03:58PM +0200, Peter Pentchev wrote: > On Tue, Dec 03, 2002 at 12:46:11PM -0800, Kris Kennaway wrote: > > On Tue, Dec 03, 2002 at 01:51:21PM -0200, Mario Sergio Fujikawa Ferreir= a wrote: > >=20 > > > Well, I apologize if I say something stupid but if a port requires > > > pthread support... not linking against it won't make the port work. I= t might > > > not even get the port to compile. > > > Wouldn't be better if a stub (with no internal code) version > > > of libc_r was cooked specially for sparc64? Just to see if the ports > > > build in that ARCH? Since nothing will really work until we have a > > > working thread implemention for sparc64. > >=20 > > I think we can just let them fail for now, unless they have a switch > > that lets them build w/o threads support. >=20 > Okay then, how about the attached minimalistic patch for the mhash port? > It builds and works just fine on sparc64 without the -lc_r linker option. If you're certain it works without thread support, by all means commit :) The patch looks clean. > Index: ports/security/mhash/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/ncvs/ports/security/mhash/Makefile,v > retrieving revision 1.17 > diff -u -r1.17 Makefile > --- ports/security/mhash/Makefile 21 May 2002 17:53:20 -0000 1.17 > +++ ports/security/mhash/Makefile 4 Dec 2002 10:50:20 -0000 > @@ -15,8 +15,13 @@ > =20 > INSTALLS_SHLIB=3D yes > USE_LIBTOOL=3D yes > + > +.include > + > +.if ${ARCH} !=3D sparc64 > CONFIGURE_ARGS+=3D --with-LDFLAGS=3D"${PTHREAD_LIBS}" > +.endif > =20 > MAN3=3D mhash.3 > =20 > -.include > +.include --=20 Mario S F Ferreira - DF - Brazil - "I guess this is a signature." Computer Science Undergraduate | FreeBSD Committer | CS Developer flames to beloved devnull@someotherworldbeloworabove.org feature, n: a documented bug | bug, n: an undocumented feature To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message