From owner-svn-src-head@freebsd.org Tue May 8 23:09:35 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9C208FCD19B; Tue, 8 May 2018 23:09:35 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (unknown [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C2996A08C; Tue, 8 May 2018 23:09:35 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-it0-f42.google.com (mail-it0-f42.google.com [209.85.214.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id 0DC8E247DA; Tue, 8 May 2018 23:09:35 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-it0-f42.google.com with SMTP id j186-v6so18326476ita.5; Tue, 08 May 2018 16:09:35 -0700 (PDT) X-Gm-Message-State: ALKqPweY3z+QozdQNlBR8hTxkqXWFvjj+7AIvqE8kXhIDqMBazomxbEb SPaNS6eUvn0lSaOr+mzARGw1iS09eivML0bVIU4= X-Google-Smtp-Source: AB8JxZq3rTkU5olB4ayO/jGGhmOJ8KUH+nVbhQcVheKMwmkPs4MQpyHdgRrm4/KJUq7N6dKCrmJ2ZdtsItckdN+AOeg= X-Received: by 2002:a24:5a85:: with SMTP id v127-v6mr7881807ita.128.1525820974345; Tue, 08 May 2018 16:09:34 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:b0c3:0:0:0:0:0 with HTTP; Tue, 8 May 2018 16:09:33 -0700 (PDT) In-Reply-To: <20180508221025.GA4249@raichu> References: <201805080139.w481djMX062724@repo.freebsd.org> <20180508221025.GA4249@raichu> From: Matthew Macy Date: Tue, 8 May 2018 16:09:33 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r333345 - head/sys/dev/e1000 To: Mark Johnston Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 23:09:35 -0000 Is the e1000 driver compiled in or loaded as a module? -M On Tue, May 8, 2018 at 3:10 PM, Mark Johnston wrote: > On Tue, May 08, 2018 at 01:39:45AM +0000, Matt Macy wrote: >> Author: mmacy >> Date: Tue May 8 01:39:45 2018 >> New Revision: 333345 >> URL: https://svnweb.freebsd.org/changeset/base/333345 >> >> Log: >> Sleep rather than spin in e1000 when doing long running config operations. >> >> With r333218 it is now possible for drivers to use an sx lock and thus sleep while >> waiting on long running operations rather than DELAY(). >> >> Reported by: gallatin >> Reviewed by: sbruno >> Approved by: sbruno >> MFC after: 1 month >> Sponsored by: Limelight Networks >> Differential Revision: https://reviews.freebsd.org/D14984 > > I'm getting a panic during boot with this change: "unknown mac type d". > > It occurs while the driver is attaching to: > > em0@pci0:1:0:0: class=0x020000 card=0x7044103c chip=0x105e8086 rev=0x06 hdr=0x00 > vendor = 'Intel Corporation' > device = '82571EB Gigabit Ethernet Controller' > class = network > subclass = ethernet