From nobody Thu Dec 5 00:52:16 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y3bSx1cP7z5fVM4 for ; Thu, 05 Dec 2024 00:52:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y3bSw4kq1z4g6c for ; Thu, 5 Dec 2024 00:52:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733359936; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RftqnA+67ATyv6yMV5GhUJ8FY6No5sgbqL2arUYmdQU=; b=pq7DMYce7GoT5geyWQ84yLTU4IgyVdR9H9pnXwI/YJbKVHa4q+tLgyUzfBbHwOh1RBoqeR C0Djn8ajyN7vrSgxQrkwjCF+F+5LDPWEJxqXaLOYAGuDzeSukX8QKHX8FFnLkWvzSQFPm0 C7R35N/kQXhuNP/0WOEi38dEifazFKJJpR6wYeZaRlBxzwMdvw3+F+8hdaOpcwO/woJzKb 5AEMx42L9HLyyGE4GnKOtG1OkFyajHG9/d8eciojGMzmI6Te3dlLqkdZaJBJztyVi9KuN4 n6AFIn9hSgmD796FohECB526XM1jPvNO/IcQVLhSDdaxaIXPcCJwIs4MpJ5Vlw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1733359936; a=rsa-sha256; cv=none; b=IXvZ8/RpQWMBho+mnaGpeTZB6O25o/px74Mt/FecxQfClhTObPVpA0e3rQObDflSrEKb4s 7rn2kD9y1cDYW3gtI6vwgP5J/g17QouNa5FxflNo9rF48y+xwkWXeBX92c1MBO1ftEzaO4 +uePSU0Qb2bvMembe1i2RxOlpnN4uKwG7fH4EbZ28BknF8rJlBYK9XaJBNrwayylO8OHB2 SHIQ0cKa/tsxkz7NLU93VzjOB2VwJY1Ye7xLuvB6J3RcAWNilKxuwsa8OVEvSeOIGtj/SA pUm5CfIPs4h44MqEPAnOR0oKQFqeQCboxQAOCwAC9aPDv44nnAtYeudQvCSjYw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Y3bSw33gyzWvh for ; Thu, 5 Dec 2024 00:52:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4B50qG70065550 for ; Thu, 5 Dec 2024 00:52:16 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4B50qGfi065549 for bugs@FreeBSD.org; Thu, 5 Dec 2024 00:52:16 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 272787] Add asmc support for MacBookPro10,1, MacMini6,2, and MacBookPro8,3 Date: Thu, 05 Dec 2024 00:52:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jwb@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D272787 --- Comment #6 from Jason W. Bacon --- (In reply to ed crowe from comment #4) Thanks, updating to=20 case ASMC_ALSL_INT2A: /* * This suppresses console and log messages for the ambient * light sensor for models known to generate this interrupt. */ if (strcmp(sc->sc_model->smc_model, "MacBookPro5,5") =3D=3D= 0 || strcmp(sc->sc_model->smc_model, "MacBookPro6,2") =3D=3D= 0 || strcmp(sc->sc_model->smc_model, "MacBookPro8,3") =3D=3D= 0) break; has silenced the log messages. I'll give some thought to a pull request, b= ut I'd like to improve on the rest of the patch first. Most of the values of dev.asmc look reasonable, but I don't even know what some of them represent= , or if they're relevant to this model, e.g. dev.asmc.0.temp.TCTD: 0 dev.asmc.0.fan.1.safespeed: -1 dev.asmc.0.light.control: 0 I'll see if I can dig up some info on this. --=20 You are receiving this mail because: You are the assignee for the bug.=