From nobody Sun Mar 31 21:45:53 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V774P63G0z5GVh8; Sun, 31 Mar 2024 21:45:57 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V774P5TJJz4nvh; Sun, 31 Mar 2024 21:45:57 +0000 (UTC) (envelope-from tijl@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711921557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+uTIOIuWJJlM84pODJS9RiioXrLjtRzcXp+jzIm/uBQ=; b=JhFO/6rm3/jwfMoma5N0Ut5HwaX7kdRXBDyulQ/csHd85ZRu6nRKHRXsRhXrHiK6CMCvkW gJ1eBvn83GXLoWLeOmUMZnMQ5yNirQb77t1qGTKJZNx1DLOkSlsHMH97UIJVNtibDklA07 4HI3J1+71stQH2k1+vncHSZeW5fy9ISoyyagQmsDQP/pRpR1gazQvaJKXkZuIPTKkrm1Fn rx1nXhY575ZCNaYgF7uzkj/r2AQxvPFt4oR1gLooNQC13U7Dx5SpAQz/XOiiETwPtbZJRm 3XxQG/QRwvchfyOzBPFhA9YbL3V7rQQeP+bqLBiqakXBIDmbdcTMZAc5pBBh1Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711921557; a=rsa-sha256; cv=none; b=pRMTi8ioXpRe2y/m/7TeDlpm6baSWy6b0ZzH3nAk2PG8+WBy6BPaEBPvYKTn4hu6qFRpNS ymWPYZ6KFZgR1BLbZhCdAvbPjzsp17qzb4Gr316pJeBivC2LpSXcgzmx9VH+CbMtPEaPuJ zG0ia8Q0rtwSQLi75ErF+w5nq0ZkhAy8hAX18lEmKSgcM9sxQxbigz+z8CHGqBEwBh0w/s KseVnKJT4UUUAdj9UeRPlhNDphoTbxjtQ/68XhFAtREtAN4PGzSZ+0dx0/lmZ/SedpWRQo GlEHIxb4JHT1MONPbCAnR6xOAEk45UVst9v1/Z1oYDgRkbd9ku/Gx+D+uOpLtw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711921557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+uTIOIuWJJlM84pODJS9RiioXrLjtRzcXp+jzIm/uBQ=; b=qXT1+0nWSdQBG34gaFdhRD7xVKVjBAwonwCXzBto5h6/fFTgOOkEWOomoWkQHAipOmRKna 2RK0b/5YS1W19oRQs9hsMFd2hJrOk9kJ0efE4SPSHwvCGQhD1KYU06JxAa06FyqT6mpT2C 0wV7irv29CJvCvcMoXU9TJ+lKNO1GyZ5C8IuEmWwbu2r8uu3QSNSK9tpWxVg7pcMST7/kh aBEPQFe9hOINt3lvCyQdh3QU8B9huXsuznjsmJuFmWUqfwFp9UkFNEhXl5uS0mKSXIYu0x 2MOFJ+2WpGxuCvJGDIRJF1Jd8Adzo5rriyyL0/MPb8tGQPDTRakA06rpDwyp5g== Received: from hal.tijl.coosemans.org (unknown [IPv6:2a02:a03f:994e:2800:3c4e:7f3:2980:9bec]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: tijl) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V774N6KkmzbcZ; Sun, 31 Mar 2024 21:45:56 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Date: Sun, 31 Mar 2024 23:45:53 +0200 From: =?UTF-8?B?VMSzbA==?= Coosemans To: Po-Chuan Hsieh Cc: "Tobias C. Berner" , Gleb Popov , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update" Message-ID: <20240331234553.1793b816@hal.tijl.coosemans.org> In-Reply-To: References: <202403231404.42NE4baU095633@gitrepo.freebsd.org> <2567403.0dHE6SNnxz@angua.firefly> <20240324202715.5d18838d@hal.tijl.coosemans.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 1 Apr 2024 04:17:09 +0800 Po-Chuan Hsieh wrote: > On Mon, Mar 25, 2024 at 3:27=E2=80=AFAM T=C4=B3l Coosemans wrote: >> - You are using upstream distfiles that are quite large. The distfiles >> for the common (Latin, Greek, Cyrillic) fonts Sans, Sans Mono, and >> Serif add up to 234MB. These fonts will be installed by almost every >> user that uses FreeBSD as a desktop now that DejaVu appears to have >> been abandoned. My proposal was to create our own distfiles and I >> integrated that into makesum so the only extra step compared to a >> normal version update was to upload the generated distfile to >> freefall. I was willing to take over maintainership in case you >> didn't want to deal with that. These distfiles add up to 27MB. And >> if we put the extra weights (ExtraBold,...) and widths (Condensed,...) >> in a separate port like you did it would be only 2MB. =20 >=20 > The committed one is my second version of noto fonts update. > The previous version is to use the individual file from github.com just > like those Noto CJK ports. > I changed to upstream tarball because it's clearer/simpler and easier to > track. > I could change it back to the previous version for a smaller distfile > footprint. > Give me several days to clean up the Makefiles. Okay. >> - Some fonts have been split into x11-fonts/-basic providing Bold, >> BoldItalic, Italic, and Regular, and x11-fonts/-extra providing >> additional styles. Only some of these have x11-fonts/ as a >> metaport currently. This needs to be made consistent. I think it >> would be best to drop the metaports and move x11-fonts/-basic to >> x11-fonts/. That way pkg install installs the common >> styles for all fonts. I think that this would be the most >> intuitive/convenient. >> (I was hoping to use subpackages for this instead of extra ports.) >=20 > The -basic/-extra structure was kept for minimal change. > I agree with you that it would be better to be consistent with all other > noto ports. > I could merge the following ports: > - noto-sans-basic/-extra > - noto-sans-mono-basic/-extra > - noto-sans-symbols-basic/-extra > - noto-serif-basic/-extra > However, what should be noto-basic's dependencies after the merge? It's okay to keep the -extra ports. What I meant was to rename the -basic ports so noto-sans-basic becomes noto-sans for example. >> - x11/noto-emoji now installs the COLRv1 version of Noto Color Emoji but >> this isn't supported yet by graphics/cairo so emoji are broken now in >> gtk applications. I think Ghostscript doesn't support it either. It >> has to be removed again for now. >=20 > It is handled in PR 278019 and > ports 2878ca490586207c3cd7bb3ff94d1274f52013b0. Okay. >> - Besides Noto Color Emoji there's also the monochrome Noto Emoji that >> can be useful in print. I think we should let x11-fonts/noto-emoji >> install the monochrome font and move the existing x11-fonts/noto-emoji >> to x11-fonts/noto-color-emoji so the names match. >=20 > How about putting all emoji in the existing port (x11-fonts/noto-emoji)? That's up to you as maintainer. I would keep them apart because they have different releases, version numbers and different upstreams. For NotoEmoji there are also additional weights you could put in an -extra port: NotoEmoji-Light.ttf (extra) https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGWuo= b_10jwvS-FGJCMY.ttf NotoEmoji-Regular.ttf (basic) https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGWuo= b-r0jwvS-FGJCMY.ttf NotoEmoji-Medium.ttf (extra) https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGWuo= b-Z0jwvS-FGJCMY.ttf NotoEmoji-SemiBold.ttf (extra) https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGWuo= b911TwvS-FGJCMY.ttf NotoEmoji-Bold.ttf (basic) https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGWuo= b9M1TwvS-FGJCMY.ttf