From owner-svn-ports-all@FreeBSD.ORG Tue Jul 1 13:37:46 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C149C739; Tue, 1 Jul 2014 13:37:46 +0000 (UTC) Received: from smtpout6.timeweb.ru (smtpout6.timeweb.ru [92.53.117.39]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 70EAE220B; Tue, 1 Jul 2014 13:37:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=amdmi3.ru; s=dkim; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=0JEc7qYqCMJ7dAVnmISdf3zR454o2rOi7A51XKM3zbQ=; b=ks1/B5e/bnzoKZsZohagseeER6HWd0zvwvS5gR4inU2J26C6VcXaKM919H4C90FWTG0hXx+PyWFYaV/qEb+RVoHfw5JoP9EGGKs8MGkrEDN5Eq1w07XDhF7nnvIgqEL3ek8WrPnO3MC1LGkfZRbfuu55wco7sxC8lsvWdsn6zXg=; Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1X1yFb-0003E8-74; Tue, 01 Jul 2014 17:37:35 +0400 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id CCECA317; Tue, 1 Jul 2014 17:37:34 +0400 (MSK) Received: by hades.panopticon (Postfix, from userid 1000) id 8853617AA2; Tue, 1 Jul 2014 17:37:34 +0400 (MSK) Date: Tue, 1 Jul 2014 17:37:34 +0400 From: Dmitry Marakasov To: Tijl Coosemans Subject: Re: svn commit: r359947 - head/textproc/modlogan Message-ID: <20140701133734.GA55025@hades.panopticon> References: <201407010118.s611Ioqd040717@svn.freebsd.org> <20140701105406.Horde.6NhjjnAsUp1YnKzeh8gy5w1@webmail.leidinger.net> <20140701113313.78607107@kalimero.tijl.coosemans.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20140701113313.78607107@kalimero.tijl.coosemans.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-ports-head@freebsd.org, Alexander Leidinger , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jul 2014 13:37:46 -0000 * Tijl Coosemans (tijl@FreeBSD.org) wrote: > >> Author: amdmi3 > >> Date: Tue Jul 1 01:18:50 2014 > >> New Revision: 359947 > >> URL: http://svnweb.freebsd.org/changeset/ports/359947 > >> QAT: https://qat.redports.org/buildarchive/r359947/ > >> > >> Log: > >> - Drop .la files, no dependees require them > >> - Remove indefinite article from COMMENT > > > > Last time I checked (long ago, but as there was not much change since > > then I consider it still valid until proved otherwise) modlogan > > dlopen()ed .la files. If you haven't run-checked that it works, please > > revert this commit. > > In the configure.in file everything related to libltdl is in comments > and the code only calls dlopen, not lt_dlopen, so I think it's ok. Correct. For ports which install plugins with .la files, I check whether plain old dlopen (which can't load .la's) is used - in this case removing .la's should be safe. I've rechecked this one - it loads plugins corrently. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru