From owner-freebsd-current  Sat Mar  6  8:41:21 1999
Delivered-To: freebsd-current@freebsd.org
Received: from wall.polstra.com (rtrwan160.accessone.com [206.213.115.74])
	by hub.freebsd.org (Postfix) with ESMTP id 1281D15234
	for <current@freebsd.org>; Sat,  6 Mar 1999 08:41:18 -0800 (PST)
	(envelope-from jdp@polstra.com)
Received: from vashon.polstra.com (vashon.polstra.com [206.213.73.13])
	by wall.polstra.com (8.9.1/8.9.1) with ESMTP id IAA21472;
	Sat, 6 Mar 1999 08:41:01 -0800 (PST)
	(envelope-from jdp@polstra.com)
From: John Polstra <jdp@polstra.com>
Received: (from jdp@localhost)
	by vashon.polstra.com (8.9.2/8.9.1) id IAA44512;
	Sat, 6 Mar 1999 08:41:00 -0800 (PST)
	(envelope-from jdp@polstra.com)
Date: Sat, 6 Mar 1999 08:41:00 -0800 (PST)
Message-Id: <199903061641.IAA44512@vashon.polstra.com>
To: green@unixhelp.org
Subject: Re: callout changes nit
In-Reply-To: <Pine.BSF.4.05.9903061057250.11342-100000@janus.syracuse.net>
Organization: Polstra & Co., Seattle, WA
Cc: current@freebsd.org
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

In article <Pine.BSF.4.05.9903061057250.11342-100000@janus.syracuse.net>,
Brian Feldman  <green@unixhelp.org> wrote:
> I make a habit of checking out any interesting kernel changes in full, and one
> thing I found in the recent diff by Mr. Wollman for kern_timeout.c is:
> 
> +void
> +callout_init(c)
> +       struct  callout *c;
> +{
> +       bzero(c, sizeof c);
>  }
> 
> That doesn't look correct, does it?

Agreed.  I think it should be "sizeof *c".

John
-- 
  John Polstra                                               jdp@polstra.com
  John D. Polstra & Co., Inc.                        Seattle, Washington USA
  "Nobody ever went broke underestimating the taste of the American public."
                                                            -- H. L. Mencken


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message