From owner-svn-src-head@freebsd.org Fri Sep 6 03:15:19 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3E7EEDD743 for ; Fri, 6 Sep 2019 03:15:19 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2m.ore.mailhop.org (outbound2m.ore.mailhop.org [54.149.155.156]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46PjNk62xCz3GlK for ; Fri, 6 Sep 2019 03:15:18 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1567739716; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=PDTA3MlH6NLgUxeTrf59hL/2F6bjkTM6BSWRfFb4MYKiv1TvbY+iQG7Rrea0riEdXfn3sexk9Ey8Z FpjKH+wiviDO/sa6PwVab1rHVsMfayQkdvGngPhw/NzwYh5NxgfriUvglyoyCQapwon5zCWduRXVno +6MoWF6UCE8gs+OjYY3V5A0HS8vbykpDxx/+3FLWbGuXeOTxyaVPhVxvWZzbntVpYcE/lyeincMuth dvFjnHmA5DPYUucTI2nJoalU0vRBtTZ2Ev6BKYcckvMLgWDSp+3WUQ1TkfCsKXLyUp9XovSE9KvRQp vWQ61RxSpPeollat2ARgs2+f21fOkNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=7JdYn8NFKZmzwCClJkCi4U38GWzcKE4nQr8B5y2JkGA=; b=e+E04ubiAg5YTvdsVNAYznDsLsbMgz5wdREzI30/jIwamF9TovFy8Ttfw0Kvynq/IYlMECOlekSrp eY8j0vjaltAajKsYisjYCmTiS6y/5OOjCsCpn6bngOoAHWOyMQ+0CNGyUv5Ga7bx1UIGWLwfckay3b 6eSkAokj9v+5F/kiFxjb92Lm/LAqa+D2bS1YxmVPaklBYPv3tvWAeUjTFXpqWWw7VQlj990QgaK+Mt epNw/nZjbLk5MIo4jiChHK3gVZJkGk/adXEdELnzIvxOqUa8f/d4qlD0vCdwBb+tLw64zZQHWz2Bv0 SvgTAzBJUotVjEEVWv2Wy8e0lMWoL3g== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=7JdYn8NFKZmzwCClJkCi4U38GWzcKE4nQr8B5y2JkGA=; b=RzJCerweQs4eZZ8+6tfXrTfgoU84rheNCZvLoGRh4ewShuXTjHNzdr0rE9IUntEjO0+IiHSIrdQdb AV+X/0Vv7vrD9H+7P3IKOth4e0cVbry2Jaf0Q9fE3l8j+l6Dfaw7LidhTFnKjOi/sIE2RspOREvWPF 2frazxHO0vzjBeknSp/tVIFrFb4QOlAQMDiAwFiYBySIRb1dkEwRK0Eo3wELZ17TdBEBC/p+PX2uv4 KASLcAgK8qpIo3HRhEy2wsI7N69YS2Pb5y1yxDv+YAVw0hiy1rgxz0tm7rScnNIrQlmZeXsTMFaho2 O5Uhh8BJ1zHlvysO5HXOL1+gXVhy5zA== X-MHO-RoutePath: aGlwcGll X-MHO-User: 8a85ccff-d054-11e9-85ed-13b9aae3a1d2 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id 8a85ccff-d054-11e9-85ed-13b9aae3a1d2; Fri, 06 Sep 2019 03:15:14 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x863FDrn048614; Thu, 5 Sep 2019 21:15:13 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <4917d7507b6ea6c360dccda261f53052aa085f2b.camel@freebsd.org> Subject: Re: svn commit: r351918 - head/sys/kern From: Ian Lepore To: Philip Paeps , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Thu, 05 Sep 2019 21:15:12 -0600 In-Reply-To: <201909060119.x861JWrG006910@repo.freebsd.org> References: <201909060119.x861JWrG006910@repo.freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46PjNk62xCz3GlK X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; ASN(0.00)[asn:16509, ipnet:54.148.0.0/15, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Sep 2019 03:15:19 -0000 On Fri, 2019-09-06 at 01:19 +0000, Philip Paeps wrote: > Author: philip > Date: Fri Sep 6 01:19:31 2019 > New Revision: 351918 > URL: https://svnweb.freebsd.org/changeset/base/351918 > > Log: > riscv: default to HZ=100 > > Most current RISC-V development platforms are not fast enough to > benefit > from the increased granularity provided by HZ=1000. > > Sponsored by: Axiado > > Modified: > head/sys/kern/subr_param.c > > Modified: head/sys/kern/subr_param.c > ===================================================================== > ========= > --- head/sys/kern/subr_param.c Fri Sep 6 00:06:55 2019 (r351 > 917) > +++ head/sys/kern/subr_param.c Fri Sep 6 01:19:31 2019 (r351 > 918) > @@ -61,7 +61,7 @@ __FBSDID("$FreeBSD$"); > */ > > #ifndef HZ > -# if defined(__mips__) || defined(__arm__) > +# if defined(__mips__) || defined(__arm__) || defined(__riscv) > # define HZ 100 > # else > # define HZ 1000 > This seems like a bad idea. I've run a 90mhz armv4 chip with HZ=1000 and didn't notice any performance hit from doing so. Almost all arm kernel config files set HZ as an option, so that define doesn't do much for arm these days. It probably does still set HZ for various mips platforms. I would think 1000 is appropriate for anything modern running at 200mhz or more. Setting it to 100 has the bad side effect of making things like msleep(), tsleep(), and pause() (which show up in plenty of drivers) all have a minimum timeout of 10ms, which is a long long time on modern hardware. What benefit do you think you'll get from the lower number? -- Ian