From owner-svn-src-head@freebsd.org Tue Apr 26 20:42:28 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F28BBB1DBB3; Tue, 26 Apr 2016 20:42:28 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-oi0-f67.google.com (mail-oi0-f67.google.com [209.85.218.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BFBE81CC1; Tue, 26 Apr 2016 20:42:28 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-oi0-f67.google.com with SMTP id f63so3639854oig.0; Tue, 26 Apr 2016 13:42:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc; bh=FQzofyYzSjOT+aEOnfA1akLMxc0T0fIY64gVCgAP6LI=; b=ksUdWE462A0Ml9PtbkQgIt6YIf13Zkk9GbTtwd4pcTZWmqPfLXleI7JwMud9nbgTqp jkqsEOmgbsJmzp1RNdQH/tP8s10VUXRKeR87A++k88+ciTCuxaAAJCzbpxjwibC6JnrC Mt6n1+dxdCYrDRPRg+nPEWg3xum9HMqLxq8++ljjUPtmjLiFK4aH8GKE9EUH/UGDzs1p mQmG5jnYoUYMkdr6y3HvR0GFL7W+J8mcl578+XsAsb5Xk/S2KB3GK7Epd+Wiy6TnZ7Ez L9iQTjFca7VIgVWdw2ACDgHWgkszkwYQhTTwCGCme5sPBaOhzqFBo/u8exiAnniNjJpP TWHA== X-Gm-Message-State: AOPr4FUw4yThr7EFYP8xON9kZDJd0ef/wopx0ikli4tdl73t9XIHzjDe2A2hAcniTBnWBw== X-Received: by 10.202.85.2 with SMTP id j2mr1727956oib.6.1461703347643; Tue, 26 Apr 2016 13:42:27 -0700 (PDT) Received: from mail-ob0-f169.google.com (mail-ob0-f169.google.com. [209.85.214.169]) by smtp.gmail.com with ESMTPSA id fg6sm247602obc.9.2016.04.26.13.42.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Apr 2016 13:42:27 -0700 (PDT) Received: by mail-ob0-f169.google.com with SMTP id n10so11542602obb.2; Tue, 26 Apr 2016 13:42:27 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.226.139 with SMTP id rs11mr2047459oec.0.1461703347045; Tue, 26 Apr 2016 13:42:27 -0700 (PDT) Reply-To: cem@FreeBSD.org Received: by 10.157.6.111 with HTTP; Tue, 26 Apr 2016 13:42:26 -0700 (PDT) In-Reply-To: References: <201604261811.u3QIBjrE092471@repo.freebsd.org> Date: Tue, 26 Apr 2016 13:42:26 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r298655 - head/sys/kgssapi From: Conrad Meyer To: Alan Somers Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2016 20:42:29 -0000 I don't do stable, and that's my choice to make (and final decision). It would be appropriate to ask, "I'd like to MFC this to stable if it makes sense to do so. Does it make sense?" But I think it is totally inappropriate to try to tell me it is my job to push petty fixes to stable/10, a branch I do not use. You don't pay me to work on stable/10 and neither does anybody else. It's not my job. I do FreeBSD for fun. Conrad On Tue, Apr 26, 2016 at 1:24 PM, Alan Somers wrote: > You really ought to. When you MFC yourself, it reduces the likelihood of > errors, because you understand the change best. When someone else does it, > it's more likely he'll make a mistake, because he may not know the fine > details behind the change. In fact, it's hard for anybody else to even > know that a given change should or shouldn't be MFCed. The MFC reminder > emails only go to the committer, not to everyone. And when someone > unfamiliar with kgssapi looks at a commit message like the one below, he > doesn't know whether there's no MFC tag because the change isn't applicable > to stable/10, or because the committer forgot it, or because the committer > just "doesn't do stable". > > Please help maintain stable/10. It's everyone's job. > -Alan > > On Tue, Apr 26, 2016 at 1:23 PM, Conrad Meyer wrote: > >> Nope! I don't do stable/. >> >> On Tue, Apr 26, 2016 at 12:06 PM, Alan Somers >> wrote: >> >>> Nice catch. Will you be MFCing this to stable/10? >>> >>> On Tue, Apr 26, 2016 at 12:11 PM, Conrad E. Meyer >>> wrote: >>> >>>> Author: cem >>>> Date: Tue Apr 26 18:11:45 2016 >>>> New Revision: 298655 >>>> URL: https://svnweb.freebsd.org/changeset/base/298655 >>>> >>>> Log: >>>> kgssapi: Don't leak memory in error cases >>>> >>>> Reported by: Coverity >>>> CIDs: 1007046, 1007047, 1007048 >>>> Sponsored by: EMC / Isilon Storage Division >>>> >>>> Modified: >>>> head/sys/kgssapi/gssd_prot.c >>>> >>>> Modified: head/sys/kgssapi/gssd_prot.c >>>> >>>> ============================================================================== >>>> --- head/sys/kgssapi/gssd_prot.c Tue Apr 26 18:08:51 2016 >>>> (r298654) >>>> +++ head/sys/kgssapi/gssd_prot.c Tue Apr 26 18:11:45 2016 >>>> (r298655) >>>> @@ -101,8 +101,10 @@ xdr_gss_OID(XDR *xdrs, gss_OID *oidp) >>>> } else { >>>> oid = mem_alloc(sizeof(gss_OID_desc)); >>>> memset(oid, 0, sizeof(*oid)); >>>> - if (!xdr_gss_OID_desc(xdrs, oid)) >>>> + if (!xdr_gss_OID_desc(xdrs, oid)) { >>>> + mem_free(oid, sizeof(gss_OID_desc)); >>>> return (FALSE); >>>> + } >>>> *oidp = oid; >>>> } >>>> break; >>>> @@ -164,8 +166,10 @@ xdr_gss_OID_set(XDR *xdrs, gss_OID_set * >>>> } else { >>>> set = mem_alloc(sizeof(gss_OID_set_desc)); >>>> memset(set, 0, sizeof(*set)); >>>> - if (!xdr_gss_OID_set_desc(xdrs, set)) >>>> + if (!xdr_gss_OID_set_desc(xdrs, set)) { >>>> + mem_free(set, sizeof(gss_OID_set_desc)); >>>> return (FALSE); >>>> + } >>>> *setp = set; >>>> } >>>> break; >>>> @@ -224,8 +228,10 @@ xdr_gss_channel_bindings_t(XDR *xdrs, gs >>>> || !xdr_gss_buffer_desc(xdrs, >>>> &ch->acceptor_address) >>>> || !xdr_gss_buffer_desc(xdrs, >>>> - &ch->application_data)) >>>> + &ch->application_data)) { >>>> + mem_free(ch, sizeof(*ch)); >>>> return (FALSE); >>>> + } >>>> *chp = ch; >>>> } >>>> break; >>>> >>>> >>> >> >