Date: Mon, 20 Dec 2021 00:06:56 +0100 From: Joerg Sonnenberger <joerg@bec.de> To: dev-commits-src-all@freebsd.org Subject: Re: git: 48014c667902 - main - Try to fix syntax of "strht" instruction so that clang is happy. Message-ID: <Yb%2B7EIHHNvougpp0@bec.de> In-Reply-To: <a15bd43b-bb6d-1d0a-35f7-02e6e423c621@selasky.org> References: <202112191253.1BJCrbLc026202@gitrepo.freebsd.org> <a15bd43b-bb6d-1d0a-35f7-02e6e423c621@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 19, 2021 at 01:57:48PM +0100, Hans Petter Selasky wrote: > On 12/19/21 13:53, Hans Petter Selasky wrote: > > The branch main has been updated by hselasky: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=48014c6679024f5f1b8217508915fbcd69c2041b > > > > commit 48014c6679024f5f1b8217508915fbcd69c2041b > > Author: Hans Petter Selasky <hselasky@FreeBSD.org> > > AuthorDate: 2021-12-19 12:51:37 +0000 > > Commit: Hans Petter Selasky <hselasky@FreeBSD.org> > > CommitDate: 2021-12-19 12:52:36 +0000 > > > > Try to fix syntax of "strht" instruction so that clang is happy. > > This fixes compilation of usb(4) after 0ec590d24e415dd36e38648630a0b963412ad87e . > > MFC after: 1 week > > Sponsored by: NVIDIA Networking > > --- > > sys/arm/arm/fusu.S | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sys/arm/arm/fusu.S b/sys/arm/arm/fusu.S > > index 300ccb5f020f..fd366542b283 100644 > > --- a/sys/arm/arm/fusu.S > > +++ b/sys/arm/arm/fusu.S > > @@ -234,7 +234,7 @@ ENTRY(suword16) > > adr r3, .Lfusufault > > str r3, [r2, #PCB_ONFAULT] > > - strht r1, [r0] > > + strht r1, [r0], #0 > > Hi, > > GCC 4.8 understands the former syntax, so maybe a hint for the clang ARM > maintainers. GCC doesn't parse assembler at all. Binutils has all kinds of "convience" hacks in the ARM syntax in additional to the legacy (pre-unified) syntax. Joerg
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Yb%2B7EIHHNvougpp0>