From owner-svn-ports-all@FreeBSD.ORG Thu Jan 23 22:10:12 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 71029AD2 for ; Thu, 23 Jan 2014 22:10:12 +0000 (UTC) Received: from mail-qa0-x22e.google.com (mail-qa0-x22e.google.com [IPv6:2607:f8b0:400d:c00::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0E1091211 for ; Thu, 23 Jan 2014 22:10:11 +0000 (UTC) Received: by mail-qa0-f46.google.com with SMTP id ii20so2968769qab.33 for ; Thu, 23 Jan 2014 14:10:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=rAGtM4SvSsZvzAMbHudVshiE3CadimYnGtnPBiWmR/I=; b=VLBypkmWFW8+6zVTfT3G1nRFU3PTW1ejEoTor8kUj2HfQkyNWR1dRNYqdWKzHiV+Yd VHgAo/GaTRrmCsh6pYzcFdiwr+fDdL8zB3HTWHDodhCMgJOFZHg1PXuYCXq6964aetq0 +SvocnWcxrFbdF3v9GzXbGrQSRtQJz1gxmEHA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=rAGtM4SvSsZvzAMbHudVshiE3CadimYnGtnPBiWmR/I=; b=QjkuGzUBrwMTucmzfuCiyMJse0ZCEjioZpf4AOaL0g1zDjcattTt+A4DvCnj6AVswr 5AWleZ0iCPJhUhmLYZ19meZuVh63UV9Q1hTLFCGQZUB2FHe3aEFtXl3K12LtZ+cnd1BG KCMHkWbgjZZz0eVukhMdxBfj4egEzZMM5h/Vns2MEFKIe8vX+Ah7Yib+IFrKLO3fmwsM 1E6bJIyaliUF16kakGRiN5XN52wPsuHYSwMyZb8BmN7q4/meQdtyKWnzyj3LEtPvMv9O xWjCMvLU9arAb+vhqPwC3qJ/Xuh+8sP1Z7WRo0ja8lrAgf7ZTi45mFdqrqtW0gHFbgu/ mBIA== X-Gm-Message-State: ALoCoQnSZqdp75tYbE9hB6a34yeEhfww5cC/Bc69jvc07FUDQo0vV9VWjKARwydYypSvWMAsqdeQ X-Received: by 10.224.36.82 with SMTP id s18mr15604213qad.23.1390515011116; Thu, 23 Jan 2014 14:10:11 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.96.85.138 with HTTP; Thu, 23 Jan 2014 14:09:41 -0800 (PST) In-Reply-To: <20131226224813.GW40122@ithaqua.etoilebsd.net> References: <201312262215.rBQMF1ZF002032@svn.freebsd.org> <20131226223743.GV40122@ithaqua.etoilebsd.net> <52BCB084.3040504@marino.st> <20131226224813.GW40122@ithaqua.etoilebsd.net> From: Eitan Adler Date: Thu, 23 Jan 2014 17:09:41 -0500 X-Google-Sender-Auth: Ca9aaN4VE6zP8lJ-dRQhiyd9Ucw Message-ID: Subject: Re: svn commit: r337624 - head/games/daimonin-music To: Baptiste Daroussin Content-Type: text/plain; charset=UTF-8 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , marino@freebsd.org, "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jan 2014 22:10:12 -0000 On Thu, Dec 26, 2013 at 5:48 PM, Baptiste Daroussin wrote: > On Thu, Dec 26, 2013 at 11:41:08PM +0100, John Marino wrote: >> On 12/26/2013 23:37, Baptiste Daroussin wrote: >> > On Thu, Dec 26, 2013 at 10:15:01PM +0000, John Marino wrote: >> >> Author: marino >> >> Date: Thu Dec 26 22:15:01 2013 >> >> New Revision: 337624 >> >> URL: http://svnweb.freebsd.org/changeset/ports/337624 >> >> >> > The port itself is still wrong, NO_CHECKSUM is still being used, while >> > bsd.port.mk specifically says it is not to be used inside a port, so this should >> > either be fixed or the port should remain broken. >> > >> >> I saw later this PR: http://www.freebsd.org/cgi/query-pr.cgi?pr=170052 >> >> It is taken by eadler@. The patch itself is no longer good but at least >> there was some attempt to fix it. I did not know NO_CHECKSUM was >> internal use only. It built fine in poudriere, which is where I tested >> it. Is eadler going to follow up? or at least release the PR? >> >> John > > eadler is afk for a moment, just take the pr ;) > if he complains tell him that s my fault late reply! PRs should never be considered hard locks. I was looking into a solution that would ensure security but also not generate regular work for the maintainer. Mere data files *could* cause security issues if not validated for example if maliciously altered to cause the program to crash or run arbitrary code. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams