From owner-svn-src-projects@FreeBSD.ORG  Thu Nov 13 08:39:39 2014
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 46F1DAF6;
 Thu, 13 Nov 2014 08:39:39 +0000 (UTC)
Received: from mailrelay006.isp.belgacom.be (mailrelay006.isp.belgacom.be
 [195.238.6.172]) by mx1.freebsd.org (Postfix) with ESMTP id 8B7C860B;
 Thu, 13 Nov 2014 08:39:38 +0000 (UTC)
X-Belgacom-Dynamic: yes
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Am4GAA1tZFRbsIQk/2dsb2JhbABVBoMOgS3UNgKBHBcBAQEBAX2EAwEBBDocIxALDgoJJQ8qHgYTiEUBz0QBAQEBAQEEAQEBAQEdkFEQMweESwEEnjCWaIN9PDCCSwEBAQ
Received: from 36.132-176-91.adsl-dyn.isp.belgacom.be (HELO
 kalimero.tijl.coosemans.org) ([91.176.132.36])
 by relay.skynet.be with ESMTP; 13 Nov 2014 09:38:27 +0100
Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org
 [127.0.0.1])
 by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id sAD8cPwX001047;
 Thu, 13 Nov 2014 09:38:26 +0100 (CET)
 (envelope-from tijl@FreeBSD.org)
Date: Thu, 13 Nov 2014 09:38:25 +0100
From: Tijl Coosemans <tijl@FreeBSD.org>
To: Bruce Evans <brde@optusnet.com.au>
Subject: Re: svn commit: r274428 - projects/arm64/sys/arm64/include
Message-ID: <20141113093825.09afe65f@kalimero.tijl.coosemans.org>
In-Reply-To: <20141113111122.O1052@besplex.bde.org>
References: <201411121319.sACDJJhI070308@svn.freebsd.org>
 <20141113111122.O1052@besplex.bde.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Andrew Turner <andrew@freebsd.org>, svn-src-projects@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Nov 2014 08:39:39 -0000

On Thu, 13 Nov 2014 11:37:15 +1100 (EST) Bruce Evans <brde@optusnet.com.au> wrote:
> On Wed, 12 Nov 2014, Andrew Turner wrote:
> 
> > Log:
> >  Fix the values for __WCHAR_{MIN,MAX}
> >
> > Modified:
> >  projects/arm64/sys/arm64/include/_types.h
> >
> > Modified: projects/arm64/sys/arm64/include/_types.h
> > ==============================================================================
> > --- projects/arm64/sys/arm64/include/_types.h	Wed Nov 12 12:46:57 2014	(r274427)
> > +++ projects/arm64/sys/arm64/include/_types.h	Wed Nov 12 13:19:18 2014	(r274428)
> > @@ -94,8 +94,8 @@ typedef	__uint64_t	__vm_pindex_t;
> > typedef	__uint64_t	__vm_size_t;
> > typedef	unsigned int	___wchar_t;
> >
> > -#define	__WCHAR_MIN	__INT_MIN	/* min value for a wchar_t */
> > -#define	__WCHAR_MAX	__INT_MAX	/* max value for a wchar_t */
> > +#define	__WCHAR_MIN	__UINT_MIN	/* min value for a wchar_t */
> > +#define	__WCHAR_MAX	__UINT_MAX	/* max value for a wchar_t */
> >
> > /*
> >  * Unusual type definitions.
> 
> This looks bad.
> 
> 3 underscores for ___wchar_t is execessive.  All arches have this bug.  It
> is not even needed to give an extra level of obfuscation below __wchar_t,
> since the usual spelling __wchar_t is never used.

__wchar_t is used by clang with -fms-extensions.