Date: Fri, 08 Dec 2006 12:29:47 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Wesley Shields <wxs@atarininja.org> Cc: ports@freebsd.org Subject: Re: distfile belongs to? Message-ID: <4579CB3B.6020408@FreeBSD.org> In-Reply-To: <20061208171604.GA99857@atarininja.org> References: <20061205172803.GA51892@atarininja.org> <4575C568.70905@FreeBSD.org> <20061205194146.GC52966@atarininja.org> <20061205203120.GA53894@atarininja.org> <4575EBA8.3020601@FreeBSD.org> <BDBB52B0-3FB2-4C82-A507-4785183B3C1F@FreeBSD.org> <20061206014049.GA43656@atarininja.org> <20061207183103.GA73597@atarininja.org> <45787EAD.4030104@FreeBSD.org> <45790495.6010403@FreeBSD.org> <20061208171604.GA99857@atarininja.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Wesley Shields wrote:
> On Thu, Dec 07, 2006 at 10:22:13PM -0800, Doug Barton wrote:
>> Doug Barton wrote:
>>> Wesley Shields wrote:
>>>
>>>> Part 2 (the bsd.port.mk piece) is the patch posted by Doug with Ade's
>>>> suggestions.
>>> You missed the second patch I sent with the ${file%:*} changes.
>> One more for fun. :) I was looking through bsd.port.mk for another
>> purpose tonight and came across ${ALLFILES}. Not only does it combine
>> dist and patch files into one variable, it has the benefit of not
>> adding the : stuff to the filenames in the first place.
>>
>> Learning as I go,
>
> Me too! I've just sent your patch (thanks again) and the pkg_info
> piece.
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=106483
>
> We'll see where things go from here!
Great! I hate to say this, but I just sent a followup to the PR with a
slight mod for the show.c patch. My fault for not testing that bit
previously. Otherwise it looks fantastic, and I encourage the portmgr
folks to test it ASAP. :)
Doug
--
This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4579CB3B.6020408>