From owner-freebsd-ports@FreeBSD.ORG Fri Dec 8 20:29:49 2006 Return-Path: X-Original-To: ports@freebsd.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E179E16A403 for ; Fri, 8 Dec 2006 20:29:49 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.FreeBSD.org (Postfix) with SMTP id 8531243CA3 for ; Fri, 8 Dec 2006 20:28:49 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 339 invoked by uid 399); 8 Dec 2006 20:29:48 -0000 Received: from localhost (HELO ?192.168.0.5?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 8 Dec 2006 20:29:48 -0000 X-Originating-IP: 127.0.0.1 Message-ID: <4579CB3B.6020408@FreeBSD.org> Date: Fri, 08 Dec 2006 12:29:47 -0800 From: Doug Barton Organization: http://www.freebsd.org/ User-Agent: Thunderbird 1.5.0.8 (X11/20061125) MIME-Version: 1.0 To: Wesley Shields References: <20061205172803.GA51892@atarininja.org> <4575C568.70905@FreeBSD.org> <20061205194146.GC52966@atarininja.org> <20061205203120.GA53894@atarininja.org> <4575EBA8.3020601@FreeBSD.org> <20061206014049.GA43656@atarininja.org> <20061207183103.GA73597@atarininja.org> <45787EAD.4030104@FreeBSD.org> <45790495.6010403@FreeBSD.org> <20061208171604.GA99857@atarininja.org> In-Reply-To: <20061208171604.GA99857@atarininja.org> X-Enigmail-Version: 0.94.1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: ports@freebsd.org Subject: Re: distfile belongs to? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2006 20:29:50 -0000 Wesley Shields wrote: > On Thu, Dec 07, 2006 at 10:22:13PM -0800, Doug Barton wrote: >> Doug Barton wrote: >>> Wesley Shields wrote: >>> >>>> Part 2 (the bsd.port.mk piece) is the patch posted by Doug with Ade's >>>> suggestions. >>> You missed the second patch I sent with the ${file%:*} changes. >> One more for fun. :) I was looking through bsd.port.mk for another >> purpose tonight and came across ${ALLFILES}. Not only does it combine >> dist and patch files into one variable, it has the benefit of not >> adding the : stuff to the filenames in the first place. >> >> Learning as I go, > > Me too! I've just sent your patch (thanks again) and the pkg_info > piece. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=106483 > > We'll see where things go from here! Great! I hate to say this, but I just sent a followup to the PR with a slight mod for the show.c patch. My fault for not testing that bit previously. Otherwise it looks fantastic, and I encourage the portmgr folks to test it ASAP. :) Doug -- This .signature sanitized for your protection