From owner-cvs-ports@FreeBSD.ORG Sun Mar 14 18:15:44 2010 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 19015106566C; Sun, 14 Mar 2010 18:15:44 +0000 (UTC) (envelope-from decke@bluelife.at) Received: from mail.itac.at (mail.itac.at [91.205.172.9]) by mx1.freebsd.org (Postfix) with ESMTP id 7E3548FC0C; Sun, 14 Mar 2010 18:15:43 +0000 (UTC) Received: from [93.111.183.103] by mail.itac.at with esmtpa (Exim 4.63) (envelope-from ) id 1Nqs3Y-0004c7-U8; Sun, 14 Mar 2010 18:56:53 +0100 From: Bernhard =?ISO-8859-1?Q?Fr=F6hlich?= To: Doug Barton , Wesley Shields X-Mailer: Modest 3.1 References: <201003140407.o2E47fhJ063684@repoman.freebsd.org> <4B9C6C9E.3070902@FreeBSD.org> In-Reply-To: <4B9C6C9E.3070902@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-ID: <1268589376.8345.1.camel@Nokia-N900-42-11> X-MSMail-Priority: Normal X-Priority: 3 Date: Sun, 14 Mar 2010 18:56:18 +0100 Message-Id: <1268589378.8345.2.camel@Nokia-N900-42-11> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "mail.itac.at", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: ----- Ursprüngliche Mitteilung ----- > On 03/13/10 20:07, Wesley Shields wrote: > > wxs        2010-03-14 04:07:41 UTC > > > >  FreeBSD ports repository > > > >  Modified files: > >    www/redmine         Makefile > >  Added files: > >    www/redmine/files   redmine.in > >  Log: > >  - Add RC script. > >  > >  PR:            ports/144299 > > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=144299  Submitted by:  Bernhard > > Froehlich (maintainer)  > >  Revision Changes   Path > >  1.8      +6 -0     ports/www/redmine/Makefile > >  1.1      +32 -0    ports/www/redmine/files/redmine.in (new) > > > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/redmine/Makefile.diff?&r1=1.7&r2=1.8&f=h > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/redmine/files/redmine.in > > There are several problems with this script. [...] Content analysis details: (1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.4 ALL_TRUSTED Passed through trusted hosts only via SMTP 3.4 FH_DATE_PAST_20XX The date is grossly in the future. 0.0 MISSING_MIMEOLE Message has X-MSMail-Priority, but no X-MimeOLE Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Aw: Re: cvs commit: ports/www/redmine Makefile ports/www/redmine/files redmine.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Bernhard =?ISO-8859-1?Q?Fr=F6hlich?= List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Mar 2010 18:15:44 -0000 ----- Urspr=C3=BCngliche Mitteilung ----- > On 03/13/10 20:07, Wesley Shields wrote: > > wxs=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 2010-03-14 0= 4:07:41 UTC > > > >=C2=A0 =C2=A0 FreeBSD ports repository > > > >=C2=A0 =C2=A0 Modified files: > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 www/redmine=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Makefile > >=C2=A0 =C2=A0 Added files: > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 www/redmine/files=C2=A0 =C2=A0 =C2=A0 redmin= e.in > >=C2=A0 =C2=A0 Log: > >=C2=A0 =C2=A0 - Add RC script. > >=C2=A0 =C2=A0 > >=C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 ports/144299 > > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=3D144299=C2=A0 =C2=A0 Submit= ted by:=C2=A0 =C2=A0 Bernhard > > Froehlich (maintainer)=C2=A0 =C2=A0 > >=C2=A0 =C2=A0 Revision=C2=A0 Changes=C2=A0 =C2=A0 =C2=A0 Path > >=C2=A0 =C2=A0 1.8=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 +6 -0=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 ports/www/redmine/Makefile > >=C2=A0 =C2=A0 1.1=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 +32 -0=C2=A0 = =C2=A0 =C2=A0 =C2=A0 ports/www/redmine/files/redmine.in (new) > > > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/redmine/Makefile.diff?&= r1=3D1.7&r2=3D1.8&f=3Dh > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/redmine/files/redmine.i= n > > There are several problems with this script. Thanks for your comment. I will have a look at the issues in the next few d= ays. > 1. The REQUIRE line needs to be changed to LOGIN. This is preferred for > all local scripts, but mandatory for those which run with a non-root > [ug]id (which this one does). > > 2. Instead of command=3D%%RUBY_NAME%% it's likely you want to use > command_interpreter instead. Does the stop command work with this script > as it is currently? Yes it does work fine. I use it since a few months. The binary that is show= n with top is ruby18 and RUBY_NAME is exactly that. > 3. _flags should not be included in command_args, it will result in them > being included twice. Oh did not know that the flags are automatically append to command_args. I = will check and remove this then. > 4. Are all of the options included in _flags actually things that a user > might wish to twiddle? Should some of them be in command_args instead? Yes they are but the user should have no reason to change user and group so= this could be moved to command_args. > 5. The pidfile location looks dubious to me, but I'm not sure if putting > pid files in WWWDIR has somehow become routine? That is a bigger disussion because redmine is designed to work completely i= nside of his home directory and that includes scripts, pidfiles, tmp and ev= erything else. I have already looked at spliting that up but decided agains= t it because it would be a bad hack. > 6. And finally a minor issue, %%RC_SUBR%% should just be /etc/rc.subr. > I'll be making that change for all ports once the ports freeze is over, > so no reason not to do it now. Did not know that either. When thinking about that issues it would have bee= n good to have a few good examples or a documentation. Does that probably a= lready exist and i just haven't found it? Thanks for your comments and i will also have a look at my other startscrip= ts if they have the same problems. -- Bernhard Fr=C3=B6hlich=20 http://www.bluelife.at/