From owner-cvs-src-old@FreeBSD.ORG Fri Sep 24 18:01:50 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9009E106564A for ; Fri, 24 Sep 2010 18:01:50 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 63DF18FC15 for ; Fri, 24 Sep 2010 18:01:50 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id o8OI1oxb065129 for ; Fri, 24 Sep 2010 18:01:50 GMT (envelope-from yongari@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id o8OI1o91065128 for cvs-src-old@freebsd.org; Fri, 24 Sep 2010 18:01:50 GMT (envelope-from yongari@repoman.freebsd.org) Message-Id: <201009241801.o8OI1o91065128@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to yongari@repoman.freebsd.org using -f From: Pyun YongHyeon Date: Fri, 24 Sep 2010 18:01:43 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: RELENG_7 Subject: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Sep 2010 18:01:50 -0000 yongari 2010-09-24 18:01:43 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/bge if_bge.c if_bgereg.h Log: SVN rev 213110 on 2010-09-24 18:01:43Z by yongari MFC r211596: It seems all Broadcom controllers have a bug that can generate UDP datagrams with checksum value 0 when TX UDP checksum offloading is enabled. Generating UDP checksum value 0 is RFC 768 violation. Even though the probability of generating such UDP datagrams is low, I don't want to see FreeBSD boxes to inject such datagrams into network so disable UDP checksum offloading by default. Users still override this behavior by setting a sysctl variable or loader tunable, dev.bge.%d.forced_udpcsum. I have no idea why this issue was not reported so far given that bge(4) is one of the most commonly used controller on high-end server class systems. Thanks to andre@ who passed the PR to me. PR: kern/104826 Revision Changes Path 1.198.2.46 +41 -7 src/sys/dev/bge/if_bge.c 1.73.2.21 +2 -0 src/sys/dev/bge/if_bgereg.h