From owner-cvs-all@FreeBSD.ORG  Tue Sep 21 20:38:05 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9081B16A4D0
	for <cvs-all@FreeBSD.org>; Tue, 21 Sep 2004 20:38:05 +0000 (GMT)
Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 09E7B43D39
	for <cvs-all@FreeBSD.org>; Tue, 21 Sep 2004 20:38:05 +0000 (GMT)
	(envelope-from chitt@speakeasy.net)
Received: (qmail 7492 invoked from network); 21 Sep 2004 20:38:04 -0000
Received: from dsl093-133-046.sfo4.dsl.speakeasy.net (HELO [192.168.0.50])
	(chitt@[66.93.133.46])
	(envelope-sender <chitt@speakeasy.net>)encrypted SMTP
	for <ports-committers@FreeBSD.org>; 21 Sep 2004 20:38:04 -0000
In-Reply-To: <6C953555731EC796167031D4@[192.168.1.5]>
References: <20040921191304.808B616A4CF@hub.freebsd.org>
	<6C953555731EC796167031D4@[192.168.1.5]>
Mime-Version: 1.0 (Apple Message framework v619)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <21E59215-0C0E-11D9-A976-000A95C705DC@speakeasy.net>
Content-Transfer-Encoding: 7bit
From: Sean Chittenden <chitt@speakeasy.net>
Date: Tue, 21 Sep 2004 13:38:02 -0700
To: Mathieu Arnold <mat@FreeBSD.org>
X-Mailer: Apple Mail (2.619)
cc: Thierry Thomas <thierry@FreeBSD.org>
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/databases/postgis Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Sep 2004 20:38:05 -0000

> |   Unbreak by chasing PostgreSQL's upgrade to 7.4.5.
> |
> |  PGSQL_PORTDIR=	${WRKDIR}/../../../databases/postgresql7
> | -PGSQL_SRC=	${PGSQL_PORTDIR}/work/postgresql-7.4.3
> | +PGSQL_SRC=	${PGSQL_PORTDIR}/work/postgresql-7.4.5
>
> Looks like a pretty unmaintainable thing, I think that something like
>
> PGSQL_SRC!=     make -C ${PORTSDIR}/databases/postgresql7 -VWRKSRC
>
> is much more portable. (and PGSQL_PORTDIR is not really used 
> elsewhere).

This folks, is why in a post-freeze world a few patches will be 
introduced which will bring the world a USE_POSTGRESQL makefile tunable 
suitable for ports and will get rid of that nasty PGSQL_PORTDIR hack.  
-sc

-- 
Sean Chittenden