From owner-freebsd-current@FreeBSD.ORG Mon Jul 18 11:42:07 2011 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 01F3B106564A for ; Mon, 18 Jul 2011 11:42:07 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 539758FC1E for ; Mon, 18 Jul 2011 11:42:05 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id OAA21828 for ; Mon, 18 Jul 2011 14:42:04 +0300 (EEST) (envelope-from avg@FreeBSD.org) Message-ID: <4E241C0C.1000604@FreeBSD.org> Date: Mon, 18 Jul 2011 14:42:04 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:5.0) Gecko/20110705 Thunderbird/5.0 MIME-Version: 1.0 To: freebsd-current@FreeBSD.org References: <4E05F2A4.6060908@FreeBSD.org> In-Reply-To: <4E05F2A4.6060908@FreeBSD.org> X-Enigmail-Version: 1.2pre Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Subject: Re: Fwd: stop scheduler in panic context X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2011 11:42:07 -0000 This is a reminder that if you would like to see the code for sane panic(9) context in 9.0, then I still need at least one independent reviewer and tester for the code. Thank you. on 25/06/2011 17:37 Andriy Gapon said the following: > > I would like to ask for testing of the following patch. > Since the patch affects panic(9) context, then obviously its testing requires > getting some sort of panic, and preferably some sort of "post-panic" activity too: > doing something in kdb, dumping a core (via debugger command or in unattended > mode), resetting a machine finally. > > At minimum I hope that no regressions are introduced. > At maximum I hope that some things are improved like, e.g., crash dump succeeding > where it failed before (PR amd64/139614). > > The patch is for recent head/CURRENT. It mostly affects SMP systems, but also has > a smaller impact on UP systems. > I can try to adapt it to stable/8, if sufficient interest arises. > Please see the following message for the patch and some more details. > > -------- Original Message -------- > > I would like to present the following diff for review and discussion: > http://people.freebsd.org/~avg/stop_scheduler_on_panic.diff > > The idea is to stop scheduler in a panic context and to provide a special > environment for the only running thread, the one that called panic(9). > > I tried to make this diff as minimal as possible, it doesn't include changes that > I consider to be useful improvements and [even] bug fixes, but which generated > controversy in non-public discussions. > > If there is no negative feedback within next few days, then I plan to post the > patch to current@ to solicit some testing. I will definitely wait for positive > feedback before committing this change. I hope that I will be able to sneak it > into the 9 release (unless there are objections to this). > > Thank you! -- Andriy Gapon