From owner-svn-src-all@FreeBSD.ORG Thu Sep 3 17:07:19 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EF2DD1065692 for ; Thu, 3 Sep 2009 17:07:19 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 950AA8FC1B for ; Thu, 3 Sep 2009 17:07:19 +0000 (UTC) Received: (qmail 5810 invoked by uid 399); 3 Sep 2009 17:07:15 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 3 Sep 2009 17:07:15 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4A9FF7BD.30104@FreeBSD.org> Date: Thu, 03 Sep 2009 10:07:09 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.23 (X11/20090822) MIME-Version: 1.0 To: Anonymous References: <200909010555.n815tAkx050140@svn.freebsd.org> <4A9D4A90.30700@FreeBSD.org> <20090902092054.Q27429@mp2.macomnet.net> <4A9E7718.1080503@andric.com> <86hbvli9tg.fsf@gmail.com> In-Reply-To: <86hbvli9tg.fsf@gmail.com> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: src-committers@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, Ruslan Ermilov , svn-src-head@FreeBSD.ORG, Dimitry Andric , Maxim Konovalov Subject: Re: svn commit: r196727 - head/share/man/man5 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Sep 2009 17:07:20 -0000 Anonymous wrote: > Dimitry Andric writes: > >> On 2009-09-02 07:21, Maxim Konovalov wrote: >>>> Unless I'm missing something this should be in the src.conf man page >>>> instead of make.conf. >>> Please explain why. >> make.conf(5): >> The file make.conf contains system-wide settings that will apply to every >> build using make(1) and the standard sys.mk file. >> >> src.conf(5): >> The src.conf file contains settings that will apply to every build >> involving the FreeBSD source tree; see build(7). >> >> The MALLOC_PRODUCTION define is used inside the FreeBSD source tree >> (actually only in jemalloc, it seems). >> >> You most likely don't want it to apply 'globally', since third-party >> programs (e.g. ports) might give a totally different meaning to this >> define -- or most likely: no meaning at all. :) > > Don't you think this affects not only MALLOC_PRODUCTION but all defines > under sections "BUILDING THE KERNEL" and "BUILDING THE WORLD"? Yes, those should probably be moved as well. I've cc'ed Ruslan since he's really taken the lead on the src.conf stuff. > For example, WITHOUT_MODULES conflicts with one in archivers/p7zip. Good point. You should probably bring that to the attention of the port's maintainer. Doug -- This .signature sanitized for your protection