From owner-freebsd-current@FreeBSD.ORG  Wed Jun 27 10:50:40 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@FreeBSD.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 2AEDE16A400
	for <current@FreeBSD.org>; Wed, 27 Jun 2007 10:50:40 +0000 (UTC)
	(envelope-from dfr@rabson.org)
Received: from mail.qubesoft.com (gate.qubesoft.com [217.169.36.34])
	by mx1.freebsd.org (Postfix) with ESMTP id BF91713C48A
	for <current@FreeBSD.org>; Wed, 27 Jun 2007 10:50:37 +0000 (UTC)
	(envelope-from dfr@rabson.org)
Received: from [10.201.19.245] (doug02.dyn.qubesoft.com [10.201.19.245])
	by mail.qubesoft.com (8.13.3/8.13.3) with ESMTP id l5RAoOoU022984;
	Wed, 27 Jun 2007 11:50:28 +0100 (BST) (envelope-from dfr@rabson.org)
In-Reply-To: <20070627101249.GA1128@garage.freebsd.pl>
References: <46813AF4.4020004@crc.u-strasbg.fr>
	<C465AD69-BA88-4B02-90FA-AF8A70742F3B@rabson.org>
	<20070627070618.GC21749@garage.freebsd.pl>
	<200706270837.28175.dfr@rabson.org>
	<20070627101249.GA1128@garage.freebsd.pl>
Mime-Version: 1.0 (Apple Message framework v752.2)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <0BA830D6-D3EA-4E07-A004-CD22DC473901@rabson.org>
Content-Transfer-Encoding: 7bit
From: Doug Rabson <dfr@rabson.org>
Date: Wed, 27 Jun 2007 11:50:15 +0100
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
X-Mailer: Apple Mail (2.752.2)
X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED autolearn=failed 
	version=3.0.4
X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.qubesoft.com
X-Virus-Scanned: ClamAV 0.86.2/3540/Wed Jun 27 03:54:27 2007 on
	mail.qubesoft.com
X-Virus-Status: Clean
Cc: Philippe Pegon <Philippe.Pegon@crc.u-strasbg.fr>, current@FreeBSD.org
Subject: Re: nfs on zfs panic
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Jun 2007 10:50:40 -0000


On 27 Jun 2007, at 11:12, Pawel Jakub Dawidek wrote:

> On Wed, Jun 27, 2007 at 08:37:27AM +0100, Doug Rabson wrote:
>> On Wednesday 27 June 2007, Pawel Jakub Dawidek wrote:
>>> On Tue, Jun 26, 2007 at 06:10:44PM +0100, Doug Rabson wrote:
>>>> It looks like nvp is NULL at the point where it crashed. Looking at
>>>> the zfs code, zfs_vget always returns zero, even if it failed to
>>>> find a vnode which matches the given 'inode' number. Try changing
>>>> the return statement in zfs_vget from 'return (0)' to 'return
>>>> (err)'.
>>>
>>> Your analysis is correct, can you commit this?
>>
>> I tried to commit it but got the 'need Approved by: re' message.  
>> Do you
>> have blanket re approval for this stuff?
>
> Nope. Could you ask re@ for approval? If you don't have time, I'll
> handle this later.

I'll sort things out with re@.