From owner-cvs-all@FreeBSD.ORG  Sat Nov 24 19:47:49 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1CCB916A420;
	Sat, 24 Nov 2007 19:47:49 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id A988213C45B;
	Sat, 24 Nov 2007 19:47:48 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 3B33346F8B;
	Sat, 24 Nov 2007 14:50:48 -0500 (EST)
Date: Sat, 24 Nov 2007 19:47:23 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Attilio Rao <attilio@FreeBSD.org>
In-Reply-To: <200711240422.lAO4MSGT071285@repoman.freebsd.org>
Message-ID: <20071124194615.Y14018@fledge.watson.org>
References: <200711240422.lAO4MSGT071285@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_lock.c src/sys/sys lockmgr.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Nov 2007 19:47:49 -0000

On Sat, 24 Nov 2007, Attilio Rao wrote:

> attilio     2007-11-24 04:22:28 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/kern             kern_lock.c
>    sys/sys              lockmgr.h
>  Log:
>  transferlockers() is a very dangerous and hack-ish function as waiters
>  should never be moved by one lock to another.
>  As, luckily, nothing in our tree is using it, axe the function.
>
>  This breaks lockmgr KPI, so interested, third-party modules should update
>  their source code with appropriate replacement.
>
>  Ok'ed by: ups, rwatson

"Ok'd by" doesn't generally seem to be a convention for FreeBSD commit 
messages--I'd suggest "discussed with" which makes it seem a bit less like 
approval, which is generally captured with "approved by".

Robert N M Watson
Computer Laboratory
University of Cambridge

>  MFC after: 3 days
>
>  Revision  Changes    Path
>  1.113     +0 -28     src/sys/kern/kern_lock.c
>  1.54      +0 -1      src/sys/sys/lockmgr.h
>