From owner-freebsd-current@freebsd.org Mon Feb 13 18:52:03 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 96E49CDD298 for ; Mon, 13 Feb 2017 18:52:03 +0000 (UTC) (envelope-from hackagadget@gmail.com) Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2CFBE1ED4; Mon, 13 Feb 2017 18:52:03 +0000 (UTC) (envelope-from hackagadget@gmail.com) Received: by mail-wm0-x231.google.com with SMTP id c85so315613874wmi.1; Mon, 13 Feb 2017 10:52:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RaM24L7Tz+LfJ6F7CqL/1lHnPpuz7oG1jrbyhdfCszE=; b=rA9FU08mtnu2Xudlrlki8nyopL2UZH8PHRrktoarEQBlhXaauSEID1yYWMI9X6htoR gmNdL8bmdx/b6qjb9saV5jU0HALr2vD5XWIwaVe70XPJYEhIyk2t2ONFIYRp2zwCrYEb N0RdXdcIRbec8wdlJ8cJykcvrRvYgx/v0thY21lv4quekeuOQWH/0SBXrqo3ieq+LbrL bDMTx0c8RBOnq/Ia43Jo7YD4gi9zEYCclK5iCJL1vx/SfiihQXXE1Vc1rf3cJhrNelYS jXzXzIhB5aox3tTRRbSTvrd2hScT/s/sMuVgOCKfTFbT9YDfCpjM44AT7/hmtOWt1GBL NQNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RaM24L7Tz+LfJ6F7CqL/1lHnPpuz7oG1jrbyhdfCszE=; b=jMIjrxYpxok+BT3VD0ONqCd/cOVPq3uMoK2zLWVDZb+CAy282CGp0/BcNiXN0i7Unj 2FhJ68nsqA6lhFFYs7V8NSTdsxRDFjbHvgMfFrMlX2+eSYSUTkh89EYdOrn1RvMAVMH2 8qsHqvYdlUZDMxXMSaqen6O+UmqlQzcQYgJdaC8dVQiOA80L3++Rtg3RsZKxJrYHmSZ2 2GEttARfIvoKsnKzspYv//8ZMND9BrNgDjIPAaUvqCPqcHXBaKZPHEuIiQ6AmLGodCC1 gmaXRm4AIU4uXYcD9Lzzjr02uYzdFqjMXXlGvTC6GfbIsEjodHaJKqZVFzNlX8CBhLkw wFig== X-Gm-Message-State: AMke39niViPc4AVJCzDMdXQzk/0eiwefBrdYTmoHcsJiWsCsg0sO1DHjwNGm/BTyAyXUGt4uIvSrztfffxB8eg== X-Received: by 10.28.11.131 with SMTP id 125mr1617952wml.29.1487011921587; Mon, 13 Feb 2017 10:52:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.177.166 with HTTP; Mon, 13 Feb 2017 10:52:01 -0800 (PST) Received: by 10.80.177.166 with HTTP; Mon, 13 Feb 2017 10:52:01 -0800 (PST) In-Reply-To: <2dce1a49-54b1-b31a-d376-b24434f60556@protected-networks.net> References: <2dce1a49-54b1-b31a-d376-b24434f60556@protected-networks.net> From: Stephen Kiernan Date: Mon, 13 Feb 2017 13:52:01 -0500 Message-ID: Subject: Re: SVN r313701 breaks build To: Michael Butler Cc: FreeBSD Current , "Stephen J. Kiernan" X-Mailman-Approved-At: Mon, 13 Feb 2017 19:42:40 +0000 Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Feb 2017 18:52:03 -0000 Thanks for point that out. I'm not sure how that slipped in when I built all machine types before review submission. I'll commit a fix for the break. On Feb 13, 2017 1:43 PM, "Michael Butler" wrote: > An opening brace was missed in the change; fix as below: > > > Index: sys/dev/md/md.c > =================================================================== > --- sys/dev/md/md.c (revision 313701) > +++ sys/dev/md/md.c (working copy) > @@ -1860,7 +1860,7 @@ > sbuf_printf(sb, "%s%s\n", indent, > type); > if ((mp->type == MD_VNODE && mp->vnode != NULL) || > - (mp->type == MD_PRELOAD && mp->file[0] != > '\0')) > + (mp->type == MD_PRELOAD && mp->file[0] != > '\0')) { > sbuf_printf(sb, "%s", indent); > g_conf_printf_escaped(sb, "%s", mp->file); > sbuf_printf(sb, "\n"); > >