From owner-freebsd-isdn Tue Sep 10 10:54:30 2002 Delivered-To: freebsd-isdn@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E6BBA37B400 for ; Tue, 10 Sep 2002 10:54:28 -0700 (PDT) Received: from mailout11.sul.t-online.com (mailout11.sul.t-online.com [194.25.134.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B00943E6A for ; Tue, 10 Sep 2002 10:54:28 -0700 (PDT) (envelope-from garyj@jennejohn.org) Received: from fwd10.sul.t-online.de by mailout11.sul.t-online.com with smtp id 17opDW-0008Ea-01; Tue, 10 Sep 2002 19:54:26 +0200 Received: from peedub.jennejohn.org (520017439985-0001@[217.228.218.56]) by fmrl10.sul.t-online.com with esmtp id 17opD8-1ZxXDUC; Tue, 10 Sep 2002 19:54:02 +0200 Received: from peedub.jennejohn.org (localhost [127.0.0.1]) by peedub.jennejohn.org (8.12.6/8.11.6) with ESMTP id g8AHrkcF001670; Tue, 10 Sep 2002 19:53:51 +0200 (CEST) (envelope-from garyj@peedub.jennejohn.org) Message-Id: <200209101753.g8AHrkcF001670@peedub.jennejohn.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.3 To: Poul-Henning Kamp Cc: isdn@freebsd.org Subject: Re: Found a cheap ISDN card today -- and a bug in -CURRENT Reply-To: Gary Jennejohn In-reply-to: Your message of "Tue, 10 Sep 2002 18:41:37 +0200." <11464.1031676097@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 10 Sep 2002 19:53:46 +0200 From: Gary Jennejohn X-Sender: 520017439985-0001@t-dialin.net Sender: owner-freebsd-isdn@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Poul-Henning Kamp writes: > In message <200209101434.g8AEYb1Z001069@peedub.jennejohn.org>, Gary Jennejohn > w > rites: > >Poul-Henning Kamp writes: > >> > >> I found a pre-owned PCI ISDN card for 3euro today, and promptly > >> went back home to plug it into my -current machine: > >> > >> Anyone interested ? > >> > > > >I think the driver is missing an mtx_initialize() of the mutex > >in struct ifq. I added it to a bunch of drivers, but not to > >layer1/itjc/i4b_itjc_pci.c. Try adding it and see what happens. > > Bingo, thanks. > > I'm surprised to see so much repeated code in all the layer1 > drivers, couldn't some of this be factored out to central code ? > Yeah, a general cleanup wouldn't hurt in the least. But all this stuff just "grew like topsy". --- Gary Jennejohn / garyj@jennejohn.org gj@freebsd.org gj@denx.de To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-isdn" in the body of the message