From owner-freebsd-audit@FreeBSD.ORG Tue Apr 6 02:25:24 2004 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D0C216A4CE; Tue, 6 Apr 2004 02:25:24 -0700 (PDT) Received: from smtp2.enst.fr (enst.enst.fr [137.194.2.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 98EB343D2D; Tue, 6 Apr 2004 02:25:23 -0700 (PDT) (envelope-from beyssac@enst.fr) Received: from bofh.enst.fr (bofh.enst.fr [137.194.32.191]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "bofh.enst.fr", Issuer "ENST CA" (verified OK)) by smtp2.enst.fr (Postfix) with ESMTP id CE3A853F7A; Tue, 6 Apr 2004 11:24:29 +0200 (CEST) Received: from enst.fr (localhost [127.0.0.1]) by bofh.enst.fr (8.12.11/8.12.11) with ESMTP id i369OU4T032287 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 6 Apr 2004 11:24:30 +0200 (CEST) (envelope-from beyssac@enst.fr) Received: (from beyssac@localhost) by enst.fr (8.12.11/8.12.11/Submit) id i369OTJw032286; Tue, 6 Apr 2004 11:24:29 +0200 (CEST) (envelope-from beyssac) Date: Tue, 6 Apr 2004 11:24:29 +0200 From: Pierre Beyssac To: "Jacques A. Vidrine" , audit@FreeBSD.org Message-ID: <20040406092429.GA31642@bofh.enst.fr> References: <20040217161920.GB712@straylight.m.ringlet.net> <20040405173424.GA2440@bofh.enst.fr> <20040405204112.GA17398@lum.celabo.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040405204112.GA17398@lum.celabo.org> User-Agent: Mutt/1.4.2.1i X-message-flag: Warning! Use of Microsoft Outlook makes your system susceptible to worms and viruses Subject: Re: fix for getipnodebyname(3) X-BeenThere: freebsd-audit@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Security Audit List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2004 09:25:24 -0000 On Mon, Apr 05, 2004 at 03:41:12PM -0500, Jacques A. Vidrine wrote: > This fix looks correct to me. Thanks for the review. Actually I just noticed I missed one occurence of "*errp = h_errno" that I'm going to fix right away. > Hey, Pierre, one wonders why you bothered posting a patch for review if > you were just going to commit it less than 3 hours later? Please allow > more time next time. Yes, I'm sorry, I was very anxious to get the fix committed and Brian answered privately regarding my main concern about threads. You're quite right, I'll leave more time for -audit next time. -- Pierre Beyssac pb@freebsd.org