From owner-freebsd-current@FreeBSD.ORG  Fri May  1 15:57:25 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 82575106567E;
	Fri,  1 May 2009 15:57:25 +0000 (UTC) (envelope-from sam@freebsd.org)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 50EE98FC19;
	Fri,  1 May 2009 15:57:25 +0000 (UTC) (envelope-from sam@freebsd.org)
Received: from trouble.errno.com (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id n41FvOW5018853
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 1 May 2009 08:57:24 -0700 (PDT) (envelope-from sam@freebsd.org)
Message-ID: <49FB1BE4.20502@freebsd.org>
Date: Fri, 01 May 2009 08:57:24 -0700
From: Sam Leffler <sam@freebsd.org>
Organization: FreeBSD Project
User-Agent: Thunderbird 2.0.0.18 (X11/20081209)
MIME-Version: 1.0
To: Bruce Simpson <bms@incunabulum.net>
References: <49E6DB25.2010601@sippysoft.com>	<b84edfa10904160238u7a94e4aw4f60372a6b99f2a2@mail.gmail.com>	<49E6FF8F.4070403@sippysoft.com>	<b84edfa10904160505s45bcee01n3e516a00d1e4dffe@mail.gmail.com>	<49ED6AD2.4010006@incunabulum.net>
	<49EDDD51.9040608@freebsd.org>	<49FAF3F5.5070609@incunabulum.net>
	<49FB1A3F.3000809@freebsd.org>
In-Reply-To: <49FB1A3F.3000809@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-DCC-CTc-dcc1-Metrics: ebb.errno.com; whitelist
Cc: Dennis Melentyev <dennis.melentyev@gmail.com>, stable@freebsd.org,
	"current@freebsd.org" <current@freebsd.org>,
	Maxim Sobolev <sobomax@sippysoft.com>
Subject: Re: kernel compile fails without AH_SUPPORT_AR5416
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 May 2009 15:57:26 -0000

Sam Leffler wrote:
> Bruce Simpson wrote:
>> Hi,
>>
>> Can you please try this patch?
>> I can't commit it until STABLE is unfrozen after 7.2-RELEASE is cut.
>>
>> Sam Leffler wrote:
>>> Bruce Simpson wrote:
>>>  
>>>> Hi,
>>>>
>>>> Looks like I'm late to the party. I was responsible for committing 
>>>> these
>>>> ath(4) changes to RELENG_7.
>>>> I can't remember if I tested the kernel compile without the
>>>> AH_SUPPORT_AR5416 option or not, I have been so incredibly busy.
>>>> ...
>>> ru had a change to fix this but decided not to; can't say why.
>>> Otherwise there is a better way to fix this which I alluded to in
>>> previous mail--use the config-generated #define that is generated for
>>> the "ath_hal" device.
> Do not modify ah_desc.h like you've done.  Add this to conf/options
>
> ATH_HAL   opt_ah.h
>
> and use that to enable AH_SUPPORT_AR5416.
>
> Also changes must go in head first.

To clarify the first comment: you've made it impossible to build code 
w/o the extended format descriptor; this is what I find unacceptable.

    Sam