From owner-svn-src-stable-12@freebsd.org  Mon Sep  2 00:31:04 2019
Return-Path: <owner-svn-src-stable-12@freebsd.org>
Delivered-To: svn-src-stable-12@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 11E08CB782;
 Mon,  2 Sep 2019 00:31:04 +0000 (UTC)
 (envelope-from emaste@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::19:3])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "mxrelay.nyi.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 46M9x36jwmz42xp;
 Mon,  2 Sep 2019 00:31:03 +0000 (UTC)
 (envelope-from emaste@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C9B4C9D48;
 Mon,  2 Sep 2019 00:31:03 +0000 (UTC)
 (envelope-from emaste@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x820V3OV094083;
 Mon, 2 Sep 2019 00:31:03 GMT (envelope-from emaste@FreeBSD.org)
Received: (from emaste@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id x820V3jO094082;
 Mon, 2 Sep 2019 00:31:03 GMT (envelope-from emaste@FreeBSD.org)
Message-Id: <201909020031.x820V3jO094082@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: emaste set sender to
 emaste@FreeBSD.org using -f
From: Ed Maste <emaste@FreeBSD.org>
Date: Mon, 2 Sep 2019 00:31:03 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject: svn commit: r351676 - stable/12/sys/dev/qlxgbe
X-SVN-Group: stable-12
X-SVN-Commit-Author: emaste
X-SVN-Commit-Paths: stable/12/sys/dev/qlxgbe
X-SVN-Commit-Revision: 351676
X-SVN-Commit-Repository: base
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-stable-12@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for only the 12-stable src tree
 <svn-src-stable-12.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-stable-12>, 
 <mailto:svn-src-stable-12-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable-12/>
List-Post: <mailto:svn-src-stable-12@freebsd.org>
List-Help: <mailto:svn-src-stable-12-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-stable-12>, 
 <mailto:svn-src-stable-12-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Sep 2019 00:31:04 -0000

Author: emaste
Date: Mon Sep  2 00:31:03 2019
New Revision: 351676
URL: https://svnweb.freebsd.org/changeset/base/351676

Log:
  MFC r351620: qlxgbe: avoid NULL deref in error case
  
  Reported by:	Dr Silvio Cesare of InfoSect
  Sponsored by:	The FreeBSD Foundation

Modified:
  stable/12/sys/dev/qlxgbe/ql_isr.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/dev/qlxgbe/ql_isr.c
==============================================================================
--- stable/12/sys/dev/qlxgbe/ql_isr.c	Mon Sep  2 00:29:16 2019	(r351675)
+++ stable/12/sys/dev/qlxgbe/ql_isr.c	Mon Sep  2 00:31:03 2019	(r351676)
@@ -793,7 +793,7 @@ ql_mbx_isr(void *arg)
 	ha = arg;
 
 	if (ha == NULL) {
-		device_printf(ha->pci_dev, "%s: arg == NULL\n", __func__);
+		printf("%s: arg == NULL\n", __func__);
 		return;
 	}