Date: Tue, 22 Dec 2015 17:18:40 +0000 (UTC) From: Andrew Turner <andrew@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r292611 - head/contrib/llvm/tools/lldb/source/Plugins/Process/FreeBSD Message-ID: <201512221718.tBMHIeEN086531@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: andrew Date: Tue Dec 22 17:18:40 2015 New Revision: 292611 URL: https://svnweb.freebsd.org/changeset/base/292611 Log: Don't adjust the program counter to an invalid address after reaching a breakpoint. The value doesn't need to be adjusted as it is already correctly returned from the kernel. This allows lldb to set breakpoints, and stop on them, however more work is needed, for example single stepping fails to stop. Discussed with: emaste Modified: head/contrib/llvm/tools/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm64.cpp Modified: head/contrib/llvm/tools/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm64.cpp ============================================================================== --- head/contrib/llvm/tools/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm64.cpp Tue Dec 22 17:01:30 2015 (r292610) +++ head/contrib/llvm/tools/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm64.cpp Tue Dec 22 17:18:40 2015 (r292611) @@ -260,13 +260,9 @@ RegisterContextPOSIXProcessMonitor_arm64 bool RegisterContextPOSIXProcessMonitor_arm64::UpdateAfterBreakpoint() { - // PC points one byte past the int3 responsible for the breakpoint. - lldb::addr_t pc; - - if ((pc = GetPC()) == LLDB_INVALID_ADDRESS) + if (GetPC() == LLDB_INVALID_ADDRESS) return false; - SetPC(pc - 1); return true; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201512221718.tBMHIeEN086531>