From owner-freebsd-current@FreeBSD.ORG Tue Mar 24 20:08:14 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D9BF1065794 for ; Tue, 24 Mar 2009 20:08:14 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id E136B8FC16 for ; Tue, 24 Mar 2009 20:08:13 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1LmCuw-000AFD-Ey; Tue, 24 Mar 2009 22:08:10 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id n2OK87pe081841 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 24 Mar 2009 22:08:07 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id n2OK87lk015351; Tue, 24 Mar 2009 22:08:07 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id n2OK87GL015350; Tue, 24 Mar 2009 22:08:07 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 24 Mar 2009 22:08:07 +0200 From: Kostik Belousov To: Jaakko Heinonen Message-ID: <20090324200807.GK31897@deviant.kiev.zoral.com.ua> References: <20090323140820.GA37093@zeeb.org> <20090324180437.GA952@a91-153-125-115.elisa-laajakaista.fi> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="utPK4TBebyzZxMrE" Content-Disposition: inline In-Reply-To: <20090324180437.GA952@a91-153-125-115.elisa-laajakaista.fi> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1LmCuw-000AFD-Ey f781d6d0106445496715d87398b40916 X-Terabit: YES Cc: 7ogcg7g02@sneakemail.com, freebsd-current@freebsd.org Subject: Re: panic: Bad link elm, nfsd related? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2009 20:08:17 -0000 --utPK4TBebyzZxMrE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 24, 2009 at 08:04:38PM +0200, Jaakko Heinonen wrote: > On 2009-03-23, Matthew West wrote: > > After 1-2 weeks, the system will panic with the following: > >=20 > > ---------- > > panic: Bad link elm 0xffffff0011febc00 next->prev !=3D elm >=20 > It looks like an attempt to remove xprt twice from tail queue due to > race. Does this patch make any difference? >=20 > %%% > Index: sys/rpc/svc.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/rpc/svc.c (revision 189918) > +++ sys/rpc/svc.c (working copy) > @@ -296,8 +296,10 @@ xprt_unregister_locked(SVCXPRT *xprt) > TAILQ_REMOVE(&pool->sp_active, xprt, xp_alink); > xprt->xp_active =3D FALSE; > } > - TAILQ_REMOVE(&pool->sp_xlist, xprt, xp_link); > - xprt->xp_registered =3D FALSE; > + if (xprt->xp_registered) { > + TAILQ_REMOVE(&pool->sp_xlist, xprt, xp_link); > + xprt->xp_registered =3D FALSE; > + } > } > =20 > void > %%% >=20 > This was also reported by Edward Fisk (Cc'd) in PR 132068. Yes, I did it, and discussed exactly the same change with dfr@. The patch only fixes symptom, the real problem is double unreg. --utPK4TBebyzZxMrE Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAknJPaYACgkQC3+MBN1Mb4jaLwCeKPzeGt2Q5aHundbZFwl9W+21 QHgAoPSm7Tl7oetj1igMlUkGF8XvlHnW =D3Y1 -----END PGP SIGNATURE----- --utPK4TBebyzZxMrE--