From owner-dev-commits-src-all@freebsd.org Mon May 17 06:55:58 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CBEC863E8A9; Mon, 17 May 2021 06:55:58 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fk8zf3tM1z4nDx; Mon, 17 May 2021 06:55:58 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 14H6toMF044176 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 17 May 2021 09:55:53 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 14H6toMF044176 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 14H6toQx044175; Mon, 17 May 2021 09:55:50 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 17 May 2021 09:55:50 +0300 From: Konstantin Belousov To: Kirk McKusick Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 9a2fac6ba65f - main - Fix handling of embedded symbolic links (and history lesson). Message-ID: References: <202105170000.14H00NgY054353@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202105170000.14H00NgY054353@gitrepo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4Fk8zf3tM1z4nDx X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 May 2021 06:55:58 -0000 On Mon, May 17, 2021 at 12:00:23AM +0000, Kirk McKusick wrote: > diff --git a/sys/sys/mount.h b/sys/sys/mount.h > index a6d750a1ff37..f341370ecd86 100644 > --- a/sys/sys/mount.h > +++ b/sys/sys/mount.h > @@ -224,7 +224,7 @@ struct mount { > int mnt_writeopcount; /* (i) write syscalls pending */ > struct vfsoptlist *mnt_opt; /* current mount options */ > struct vfsoptlist *mnt_optnew; /* new options passed to fs */ > - int mnt_maxsymlinklen; /* max size of short symlink */ > + uint64_t mnt_maxsymlinklen; /* max size of short symlink */ Thank you for the interesting reading in the commit message. Somewhat (un)related question is, why maxsymlinklen is put into struct mount? Shouldn't it be contained to struct ufsmount and similar ext2 data structure. The value is private to UFS, it has no use outside sys/ufs.