From owner-freebsd-bugs@freebsd.org Thu Jul 16 18:50:37 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2C10C36A382 for ; Thu, 16 Jul 2020 18:50:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4B73H10Q5xz3fdk for ; Thu, 16 Jul 2020 18:50:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 0E20C369FD7; Thu, 16 Jul 2020 18:50:37 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0DE7A36A115 for ; Thu, 16 Jul 2020 18:50:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B73H06h05z3fSw for ; Thu, 16 Jul 2020 18:50:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C978ECEBD for ; Thu, 16 Jul 2020 18:50:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 06GIoa3E037195 for ; Thu, 16 Jul 2020 18:50:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 06GIoawP037194 for bugs@FreeBSD.org; Thu, 16 Jul 2020 18:50:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 248024] Bluetooth L2CAP socket should not use automatically flushable PDUs (on LE at least) Date: Thu, 16 Jul 2020 18:50:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: greg@unrelenting.technology X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2020 18:50:37 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D248024 Bug ID: 248024 Summary: Bluetooth L2CAP socket should not use automatically flushable PDUs (on LE at least) Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: greg@unrelenting.technology So I've been debugging why a certain BLE device (https://github.com/open-homeautomation/miflora) did not respond to my comm= ands on FreeBSD. (bug 248015 for the ability to talk ACL via raw HCI socket was needed for t= hat debugging.) Replaying the ACL packet Linux was sending via the raw HCI socket I do get replies. Sending its L2CAP payload via an L2CAP socket.. no reply. Differen= ce? One bit: (good) 02 00 00 0b 00 07 00 04 00 10 01 00 ff ff 00 28 (bad) 02 00 20 0b 00 07 00 04 00 10 01 00 ff ff 00 28 ^ that's the PB flag set to 2! So turns out ng_l2cap_lp_send does `flag =3D NG_HCI_PACKET_START`. But our NG_HCI_PACKET_START (2) doesn't just mean "packet start"! According to the Bluetooth Core Spec v5.2 (Vol 4, Part E, 5.4.2, page 1893)= it means "First automatically flushable packet of a higher layer message (star= t of an automatically flushable L2CAP PDU)" and it's *not allowed for LE*! The laziest solution would be `flag =3D 0`, where 0 means "First non-automatically-flushable packet of a higher layer message (start of a non-automatically-flushable L2CAP PDU) from Host to Controller". But then there's the question: is there any benefit from the automatic flus= hing thing on Bluetooth Classic?? Maybe we should only use 0 on LE? --=20 You are receiving this mail because: You are the assignee for the bug.=