From owner-dev-commits-src-main@freebsd.org Thu Sep 23 20:06:17 2021
Return-Path: <owner-dev-commits-src-main@freebsd.org>
Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mailman.nyi.freebsd.org (Postfix) with ESMTP id BF6ED6AD151;
Thu, 23 Sep 2021 20:06:17 +0000 (UTC)
(envelope-from bdrewery@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
[IPv6:2610:1c1:1:6074::16:84])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
client-signature RSA-PSS (4096 bits) client-digest SHA256)
(Client CN "freefall.freebsd.org", Issuer "R3" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 4HFmQ14hwsz4VNf;
Thu, 23 Sep 2021 20:06:17 +0000 (UTC)
(envelope-from bdrewery@FreeBSD.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
t=1632427577;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=JDhCGMB56RKOy0VkTd7niwAG2so4Oh2gyzMFBtwkkeQ=;
b=NvhARjB+dAeha2gG4xrRMKUuBaercq646dUNHD0LxovgEQk1lQyg5Sq8iC1Aodn87X4H2E
fPyE8zOZQuxumUHA9Y/0wowlVzEb0Fkkwt/tYtPWNGaKNdXpzqQiseMlgNLm6D+tv+RZJv
KF3KtiJ+EsYTdTGM0NdGY+3VczKku1EscWAqqBPJwjCA4nbWAgZdm9yKlM4hjOrQ1DRHms
gkrx7633R7303SW97+sO0HJHzB6UoitBMEnWv/fcJFY/KR2ebZr5s+dh2Lz6z2SSdGs9mg
LJSOFK9zqr4vASHajK1DOPPLhy4Sa6nhKEblUwpA3Ww0FglObPtuusk6NXOx7Q==
Received: from mail.xzibition.com (unknown [127.0.1.132])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(Client did not present a certificate)
by freefall.freebsd.org (Postfix) with ESMTPS id 6221717A01;
Thu, 23 Sep 2021 20:06:17 +0000 (UTC)
(envelope-from bdrewery@FreeBSD.org)
Received: from mail.xzibition.com (localhost [172.31.3.2])
by mail.xzibition.com (Postfix) with ESMTP id 7836D214B8;
Thu, 23 Sep 2021 13:06:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at mail.xzibition.com
Received: from mail.xzibition.com ([172.31.3.2])
by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new,
port 10026)
with LMTP id kyAA-_PZ1_Bh; Thu, 23 Sep 2021 13:06:13 -0700 (PDT)
Subject: Re: git: f555b39e6bb7 - main - man: reset OPTIND before parsing args
DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com 3C4E7214AC
To: Kyle Evans <kevans@FreeBSD.org>, src-committers@FreeBSD.org,
dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
References: <202109231914.18NJELZU023086@gitrepo.freebsd.org>
From: Bryan Drewery <bdrewery@FreeBSD.org>
Organization: FreeBSD
Message-ID: <33438d0b-1925-8d44-83bb-62054b141635@FreeBSD.org>
Date: Thu, 23 Sep 2021 13:06:12 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <202109231914.18NJELZU023086@gitrepo.freebsd.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
protocol="application/pgp-signature";
boundary="XInPtLUnSy9zfyorvKeTTNAg8D5LojOC5"
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
s=dkim; t=1632427577;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=JDhCGMB56RKOy0VkTd7niwAG2so4Oh2gyzMFBtwkkeQ=;
b=JbmvAB6qK3K4C9uQ+a4gn+V1Ch1HGMe3IKLjA7Mx3XWfaFGV2vp82VchXnLsIA4I3M5is/
OJzs+kBV654jAljcDt6gqR5k9feEYokTiIw2wEIFPioo7bu06eAv8BqpQLG2cmtxrv3/Ku
iwjuRlvGHdFQVeGkFEl/uCpA4cTlHajdmoOqFzSu4p3cojY3RHCy49IRWP3xa6nIKBjSM5
GNdjenj5mOZnPBzhi8apK7QdnlJvyJ47NHXp52YmL2EqRkOApEfOc74u//WvJtTQOSZeIZ
CWh4xc1zKzYqGM8cxSIHXVl5fTWAxUDyMeKnYGMMShhwedRCjVLHFKl8cRWQYw==
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1632427577; a=rsa-sha256; cv=none;
b=o7GG0zYAmW/BPNfL9ztHnVfSptBDRLADcxA+L0Y0fQAoBiP5e0nKxjUyu6Zx9gxl/Q9tnu
1KJR3OnML1U0xrEVBy/VGoJS/uoprfcHHLxem8BQe2px8+2UU6XDSivGif1eeFxuCeIZ1v
Fe1Y2EP3Y8bd0YPwomPmJ+4A1lw5u7Eba8ipps74RQqdocbIBkmh+Jly29BQ63aaY3hgDQ
m8d1IocR0MUCqTFpkryYfBzutD2aAMleYKhq3vj1dI7/WPAgCJEZiJbEA/s/9JXc4oboal
PhCtNAJPdWMma+lozSks5Gzy/pwxAfxkH4rhr0UTK4/DG1E7vqzbTo+wMq3MMA==
ARC-Authentication-Results: i=1;
mx1.freebsd.org;
none
X-BeenThere: dev-commits-src-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for the main branch of the src repository
<dev-commits-src-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>,
<mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>,
<mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Sep 2021 20:06:17 -0000
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--XInPtLUnSy9zfyorvKeTTNAg8D5LojOC5
Content-Type: multipart/mixed; boundary="mCNiFLnztWUqqQQdqoZG1wz328xTcPbXV";
protected-headers="v1"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Kyle Evans <kevans@FreeBSD.org>, src-committers@FreeBSD.org,
dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Message-ID: <33438d0b-1925-8d44-83bb-62054b141635@FreeBSD.org>
Subject: Re: git: f555b39e6bb7 - main - man: reset OPTIND before parsing args
References: <202109231914.18NJELZU023086@gitrepo.freebsd.org>
In-Reply-To: <202109231914.18NJELZU023086@gitrepo.freebsd.org>
--mCNiFLnztWUqqQQdqoZG1wz328xTcPbXV
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
On 9/23/2021 12:14 PM, Kyle Evans wrote:
> The branch main has been updated by kevans:
>=20
> URL: https://cgit.FreeBSD.org/src/commit/?id=3Df555b39e6bb7cbfbe1905e90=
f64c4dfc4456fabb
>=20
> commit f555b39e6bb7cbfbe1905e90f64c4dfc4456fabb
> Author: Kyle Evans <kevans@FreeBSD.org>
> AuthorDate: 2021-09-22 19:58:19 +0000
> Commit: Kyle Evans <kevans@FreeBSD.org>
> CommitDate: 2021-09-23 19:13:34 +0000
>=20
> man: reset OPTIND before parsing args
> =20
> From jilles: POSIX requires that a script set `OPTIND=3D1` before u=
sing
> different sets of parameters with `getopts`, or the results will be=
> unspecified.
> =20
> The specific problem observed here is that we would execute `man -f=
` or
> `man -k` without cleaning up state from man_parse_args()' `getopts`=
> loop. FreeBSD's /bin/sh seems to reset OPTIND to 1 after we hit th=
e
> second getopts loop, rendering the following shift harmless; other
> /bin/sh implementations will leave it at what we came into the loop=
at
> (e.g., bash as /bin/sh), shifting off any keywords that we had.
> =20
> Input from: jilles
> Reviewed by: allanjude, bapt, imp
> Sponsored by: Klara, Inc.
> Differential Revision: https://reviews.freebsd.org/D32063
> ---
> usr.bin/man/man.sh | 4 ++++
> 1 file changed, 4 insertions(+)
>=20
> diff --git a/usr.bin/man/man.sh b/usr.bin/man/man.sh
> index f31c464fcc8f..084f4a06829b 100755
> --- a/usr.bin/man/man.sh
> +++ b/usr.bin/man/man.sh
> @@ -243,6 +243,7 @@ is_newer() {
> manpath_parse_args() {
> local cmd_arg
> =20
> + OPTIND=3D1
> while getopts 'Ldq' cmd_arg; do
> case "${cmd_arg}" in
> L) Lflag=3DLflag ;;
Not that it matters much but since this script makes use of 'local',
OPTIND and OPTARG might as well be in the list as well.
--=20
Bryan Drewery
--mCNiFLnztWUqqQQdqoZG1wz328xTcPbXV--
--XInPtLUnSy9zfyorvKeTTNAg8D5LojOC5
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"
-----BEGIN PGP SIGNATURE-----
wsB5BAABCAAjFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAmFM3jQFAwAAAAAACgkQNddxu25Gl8//
fAf+O3YXbK0GFvjhmxxzbVODUS2kQAq/UlrYfcNxWsxd0xGlqSbdu+N2Ky5bsnDqVJ4f8kUlnDwa
OSlDhox/c4STZBBnTHZPTrS6wHnon2QQbQpdFyEKgInRtSf3TfvChbHU2kkQIiPcr5uWEgSg4TwV
GnzvAKhccr/iEy8Vo7x/mIuqoJKyVwNamSNzQcy15hwDue4/PkG4Bu5QKRtMJidBJ3w0Wi84GQ6I
GAGb8leIiCSvuanNucPXMso5OwaJcCU+Qb/uIIwTok4x2Bm+mibmzu+bOGap6Jl1Uase/F19+tho
hY4YVViWEQyMgB3NPe9vTi8cV0nTtMjS8z108Jyr3g==
=X6MU
-----END PGP SIGNATURE-----
--XInPtLUnSy9zfyorvKeTTNAg8D5LojOC5--