From owner-svn-src-all@freebsd.org  Sun Dec  6 21:22:48 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 416B19A0C1D;
 Sun,  6 Dec 2015 21:22:48 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B6FAC1239;
 Sun,  6 Dec 2015 21:22:47 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id tB6LMgBZ010253
 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Sun, 6 Dec 2015 23:22:42 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua tB6LMgBZ010253
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id tB6LMgG7010252;
 Sun, 6 Dec 2015 23:22:42 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Sun, 6 Dec 2015 23:22:42 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: Ed Maste <emaste@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r291909 - head/sys/sys
Message-ID: <20151206212242.GI2202@kib.kiev.ua>
References: <201512062116.tB6LG1Cc058770@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201512062116.tB6LG1Cc058770@repo.freebsd.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Dec 2015 21:22:48 -0000

On Sun, Dec 06, 2015 at 09:16:01PM +0000, Ed Maste wrote:
> Author: emaste
> Date: Sun Dec  6 21:16:01 2015
> New Revision: 291909
> URL: https://svnweb.freebsd.org/changeset/base/291909
> 
> Log:
>   Add definitions for ELF note types used in executables
>   
>   Sponsored by:	The FreeBSD Foundation
> 
> Modified:
>   head/sys/sys/elf_common.h
> 
> Modified: head/sys/sys/elf_common.h
> ==============================================================================
> --- head/sys/sys/elf_common.h	Sun Dec  6 21:07:33 2015	(r291908)
> +++ head/sys/sys/elf_common.h	Sun Dec  6 21:16:01 2015	(r291909)
> @@ -727,6 +727,11 @@ typedef struct {
>  #define	LL_DELAY_LOAD		0x10
>  #define	LL_DELTA		0x20
>  
> +/* Values for n_type used in executables. */
> +#define	NT_FREEBSD_ABI_TAG	1
> +#define	NT_FREEBSD_NOINIT_TAG	2
> +#define	NT_FREEBSD_ARCH_TAG	3
> +
>  /* Values for n_type.  Used in core files. */
>  #define	NT_PRSTATUS	1	/* Process status. */
>  #define	NT_FPREGSET	2	/* Floating point registers. */
Do you plan to make a pass over the tree, switching uses of *_NOTETYPE
to NT_FREEBSD_*_TAG ?  See lib/csu/common/notes.h.

Also, sys/kern/imgact_elf.c would benefit from use of NT_FREEBSD_ABI_TAG
instead of magic '1' in brandnotes.